-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix md_mpx_format_adjuster.py script #1317
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1317 +/- ##
===========================================
+ Coverage 96.30% 96.99% +0.68%
===========================================
Files 137 137
Lines 3387 3424 +37
Branches 949 961 +12
===========================================
+ Hits 3262 3321 +59
+ Misses 119 98 -21
+ Partials 6 5 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
Please work with @noman2002 on this. He'll be taking over the review of this PR |
@Nitya-Pasrija Please be aware of this PR |
@noman2002 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
What kind of change does this PR introduce?
npm
for bothtalawa-api
andtalawa-admin
.md_mpx_format_adjuster.py
) to ensure Markdown files are MPX compatible./
Issue Number: #1279
Did you add tests for your changes?
If relevant, did you update the documentation?
script.py
.Summary
script.py
for Typedoc-generated Markdown files.Does this PR introduce a breaking change?
Have you read the contributing guide?