-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign talawa user portal settings page #1312
Redesign talawa user portal settings page #1312
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1312 +/- ##
========================================
Coverage 96.98% 96.98%
========================================
Files 137 137
Lines 3417 3417
Branches 958 958
========================================
Hits 3314 3314
Misses 98 98
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@deevejawadhwa let me know if this design looks fine to you. |
@pateldivyesh1323 can you add rhe translation box similar to the admin-settings page |
@aashimawadhwa Yes, I have added the translation box in the latest commit. videoTalawa.Admin.-.Google.Chrome.2023-12-29.13-58-26.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
What kind of change does this PR introduce?
Redesign Talawa User Portal Settings Page to Match Admin Portal Design
Issue Number:
Fixes #1306
Did you add tests for your changes?
No, the tests are up to date for the changed files.
Snapshots/Videos:
Talawa.Admin.-.Google.Chrome.2023-12-28.22-26-41.mp4
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes