Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign talawa user portal settings page #1312

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

pateldivyesh1323
Copy link
Contributor

What kind of change does this PR introduce?

Redesign Talawa User Portal Settings Page to Match Admin Portal Design

Issue Number:

Fixes #1306

Did you add tests for your changes?

No, the tests are up to date for the changed files.

Snapshots/Videos:

  • Before

image

  • After
Talawa.Admin.-.Google.Chrome.2023-12-28.22-26-41.mp4

If relevant, did you update the documentation?

No

Summary

  • Changed background colors
  • Improved margin and paddings
  • Improved width of input tags and form

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b5c168) 96.98% compared to head (1f707bf) 96.98%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1312   +/-   ##
========================================
  Coverage    96.98%   96.98%           
========================================
  Files          137      137           
  Lines         3417     3417           
  Branches       958      958           
========================================
  Hits          3314     3314           
  Misses          98       98           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beingnoble03
Copy link
Member

@deevejawadhwa let me know if this design looks fine to you.

@aashimawadhwa
Copy link
Member

@pateldivyesh1323 can you add rhe translation box similar to the admin-settings page

@pateldivyesh1323
Copy link
Contributor Author

@aashimawadhwa Yes, I have added the translation box in the latest commit.

video

Talawa.Admin.-.Google.Chrome.2023-12-29.13-58-26.mp4

Copy link
Member

@aashimawadhwa aashimawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@noman2002 noman2002 merged commit a6b1ca2 into PalisadoesFoundation:develop Dec 31, 2023
8 checks passed
@pateldivyesh1323 pateldivyesh1323 deleted the 1306 branch January 1, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants