-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper positioning of Event Statistics in the mobile view #1308
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1308 +/- ##
========================================
Coverage 96.30% 96.30%
========================================
Files 137 137
Lines 3387 3387
Branches 949 949
========================================
Hits 3262 3262
Misses 119 119
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@duplixx Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details. |
@Cioppolo14 i have fixed, Can you check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the above comments. Also, upload the after and before video screenshots effects of this PR, in the PR descriptions.
Co-authored-by: Noble Mittal <[email protected]>
yeah sure @beingnoble03 i'll make changes thanks for review!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What kind of change does this PR introduce?
Bug Fixes
Issue Number:
Fixes #1286
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?