Feature: App running with `npm install` #1291

git-init-priyanshu · 2023-12-26T13:52:15Z

What kind of change does this PR introduce?
feature

Issue Number:
Fixes #1246

Did you add tests for your changes?
No

Snapshots/Videos:
Before:

After:

If relevant, did you update the documentation?
Yes

Summary
Right now, we cannot use npm install as it throws a bunch of errors, and can only be solved by using the --legacy-peer-deps flag. This PR fixes those peer dependency issues.

Does this PR introduce a breaking change?
No.

Have you read the contributing guide?
Yes

github-actions · 2023-12-26T13:52:40Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold
Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

codecov · 2023-12-26T13:56:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3819bd8) 96.99% compared to head (9e95ecd) 97.44%.
Report is 12 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1291      +/-   ##
===========================================
+ Coverage    96.99%   97.44%   +0.45%     
===========================================
  Files          137      138       +1     
  Lines         3428     3683     +255     
  Branches       964     1076     +112     
===========================================
+ Hits          3325     3589     +264     
+ Misses          98       89       -9     
  Partials         5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aashimawadhwa · 2023-12-26T17:53:46Z

can you share a video of how npm i is working fine now? @git-init-priyanshu

git-init-priyanshu · 2023-12-26T18:56:51Z

@aashimawadhwa
https://drive.google.com/drive/folders/1r3E-92VxvLBiFpF4kpxpjvrON-yAe7Mj

palisadoes · 2023-12-26T22:56:49Z

Was the enzyme-adapter-react-16 package ever used in the code base? You've only edited the package listing.

git-init-priyanshu · 2023-12-27T07:02:33Z

Was the enzyme-adapter-react-16 package ever used in the code base? You've only edited the package listing.

No sir, it was not used in the code. The solution was to install @wojtekmaj/enzyme-adapter-react-17 package which is compatible with react 17. It was already installed and correctly used.

git-init-priyanshu · 2023-12-27T07:07:41Z

Right now I am trying to solve peer depedency warnings. And I also need to change the INSTALLATION.md for the node version.

git-init-priyanshu · 2023-12-28T07:42:59Z

Hey @aashimawadhwa can you check this PR now?

palisadoes · 2023-12-31T10:52:58Z

@noman2002 @anwersayeed @aashimawadhwa please review

noman2002 · 2023-12-31T16:26:31Z

src/screens/OrgPost/OrgPost.tsx

-                        value="searchText"
+                        // value="searchText"


Why this is commented ?

src/screens/OrgPost/OrgPost.tsx

git-init-priyanshu · 2024-01-03T10:13:13Z

hey @noman2002 @rishav-jha-mech, Sorry for my late reply, I didn't receive the notification.
I commented those two lines because I was not sure what to do as they were throwing error "Property 'value' does not exist ...". I also checked all the reference of "Dropdown.Item" in the whole codebase and the value property was only defined here. And I also checked the API of "Dropdown.Item" and there was also no mention of value property. Let me know if this is a mistake I will correct it.

…a-admin-clone into develop

…a-admin-clone into priyanshu-talawa-admin

git-init-priyanshu · 2024-01-05T08:43:09Z

hey @rishav-jha-mech @noman2002, I have fixed the issue and updated the INSTALLATION.md file.

rishav-jha-mech · 2024-01-05T08:45:57Z

hey @noman2002 @rishav-jha-mech, Sorry for my late reply, I didn't receive the notification. I commented those two lines because I was not sure what to do as they were throwing error "Property 'value' does not exist ...". I also checked all the reference of "Dropdown.Item" in the whole codebase and the value property was only defined here. And I also checked the API of "Dropdown.Item" and there was also no mention of value property. Let me know if this is a mistake I will correct it.

It maybe a eslint error, make sure you have eslint extension installed in your VS Code

package.json

rishav-jha-mech · 2024-01-05T08:48:13Z

@git-init-priyanshu after all these changes are the packages getting installed without --legacy-peer-deps with npm instal ?

git-init-priyanshu · 2024-01-05T10:01:21Z

@git-init-priyanshu after all these changes are the packages getting installed without --legacy-peer-deps with npm instal ?

yes. Here is the video proof. https://drive.google.com/drive/folders/1j66OogD9dgTzPOLHCLYjN_KAP_CCj4sO

rishav-jha-mech · 2024-01-05T13:17:33Z

@git-init-priyanshu I have seen the uploaded video, let me know if having node-sass module is causing any issue, if not then we will merge your PR

git-init-priyanshu · 2024-01-05T15:30:20Z

@git-init-priyanshu I have seen the uploaded video, let me know if having node-sass module is causing any issue, if not then we will merge your PR

Right now everything is working fine. But I found some sass files under src/assets/scss , So if these files need to be compiled then I think we do need the node-sass.

rishav-jha-mech · 2024-01-07T14:21:07Z

@git-init-priyanshu please put node-sass back into package.json, and let us know if the npm install is working or not

git-init-priyanshu · 2024-01-07T19:09:32Z

@git-init-priyanshu please put node-sass back into package.json, and let us know if the npm install is working or not

I reverted the changes. And npm install is working fine.

git-init-priyanshu added 2 commits December 26, 2023 15:50

Removed enzyme-adapter-react-16 package

bcd57ed

Removed package and updated NSTALLATION.md

97d8529

git-init-priyanshu changed the title ~~Removed package and updated NSTALLATION.md~~ Feature: App running with npm install Dec 26, 2023

Cioppolo14 requested review from noman2002 and anwersayeed December 26, 2023 14:13

palisadoes requested a review from aashimawadhwa December 27, 2023 07:27

git-init-priyanshu and others added 2 commits December 27, 2023 19:49

Fixed peer dependency issue of "node-sass"

1b557b0

Specified node version in INSTALLATION.md

362736d

noman2002 reviewed Dec 31, 2023

View reviewed changes

src/screens/OrgPost/OrgPost.tsx Outdated

value="searchText"

// value="searchText"

Copy link

Member

noman2002 Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is commented ?

rishav-jha-mech reviewed Jan 2, 2024

View reviewed changes

src/screens/OrgPost/OrgPost.tsx Outdated Show resolved Hide resolved

git-init-priyanshu added 8 commits January 5, 2024 11:05

Merge branch 'develop' of https://github.com/git-init-priyanshu/talaw…

b53bf03

…a-admin-clone into develop

Merge completed

abd4e2e

Fixed Dropdown.Item issue

28f0863

Merge branch 'develop' of https://github.com/git-init-priyanshu/talaw…

09b0c4f

…a-admin-clone into priyanshu-talawa-admin

Removed "node-sass" package.

df36705

Fixed Dropdown.Item issue

5f7bf27

Merge branch 'develop' of https://github.com/git-init-priyanshu/talaw…

9b9f9a4

…a-admin-clone into priyanshu-talawa-admin

Specified node version ^20.0.0

5d26559

rishav-jha-mech reviewed Jan 5, 2024

View reviewed changes

package.json Show resolved Hide resolved

Fixed merge conflicts

9186edf

Reverted node-sass package.

9e95ecd

rishav-jha-mech approved these changes Jan 10, 2024

View reviewed changes

rishav-jha-mech mentioned this pull request Jan 10, 2024

Create an Avatar Component with DiceBear Integration #1391

Closed

palisadoes approved these changes Jan 10, 2024

View reviewed changes

palisadoes merged commit 58389f6 into PalisadoesFoundation:develop Jan 10, 2024
9 of 10 checks passed

void-hr mentioned this pull request Jan 29, 2024

Dependency Cleanup Proposal: Remove Unused "@types/enzyme-adapter-react-16" in package.json #1517

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: App running with `npm install` #1291

Feature: App running with `npm install` #1291

git-init-priyanshu commented Dec 26, 2023 •

edited

Loading

github-actions bot commented Dec 26, 2023

codecov bot commented Dec 26, 2023 •

edited

Loading

aashimawadhwa commented Dec 26, 2023

git-init-priyanshu commented Dec 26, 2023

palisadoes commented Dec 26, 2023

git-init-priyanshu commented Dec 27, 2023

git-init-priyanshu commented Dec 27, 2023

git-init-priyanshu commented Dec 28, 2023

palisadoes commented Dec 31, 2023

noman2002 Dec 31, 2023

git-init-priyanshu commented Jan 3, 2024

git-init-priyanshu commented Jan 5, 2024

rishav-jha-mech commented Jan 5, 2024

rishav-jha-mech commented Jan 5, 2024

git-init-priyanshu commented Jan 5, 2024

rishav-jha-mech commented Jan 5, 2024 •

edited

Loading

git-init-priyanshu commented Jan 5, 2024

rishav-jha-mech commented Jan 7, 2024

git-init-priyanshu commented Jan 7, 2024

Feature: App running with npm install #1291

Feature: App running with npm install #1291

Conversation

git-init-priyanshu commented Dec 26, 2023 • edited Loading

github-actions bot commented Dec 26, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

codecov bot commented Dec 26, 2023 • edited Loading

Codecov Report

aashimawadhwa commented Dec 26, 2023

git-init-priyanshu commented Dec 26, 2023

palisadoes commented Dec 26, 2023

git-init-priyanshu commented Dec 27, 2023

git-init-priyanshu commented Dec 27, 2023

git-init-priyanshu commented Dec 28, 2023

palisadoes commented Dec 31, 2023

noman2002 Dec 31, 2023

Choose a reason for hiding this comment

git-init-priyanshu commented Jan 3, 2024

git-init-priyanshu commented Jan 5, 2024

rishav-jha-mech commented Jan 5, 2024

rishav-jha-mech commented Jan 5, 2024

git-init-priyanshu commented Jan 5, 2024

rishav-jha-mech commented Jan 5, 2024 • edited Loading

git-init-priyanshu commented Jan 5, 2024

rishav-jha-mech commented Jan 7, 2024

git-init-priyanshu commented Jan 7, 2024

Feature: App running with `npm install` #1291

Feature: App running with `npm install` #1291

git-init-priyanshu commented Dec 26, 2023 •

edited

Loading

codecov bot commented Dec 26, 2023 •

edited

Loading

rishav-jha-mech commented Jan 5, 2024 •

edited

Loading