Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage for DeleteOrg.tsx added test #1219

Closed

Conversation

VaibhavTalkhande
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Fixes #1066

Did you add tests for your changes?
yes

Snapshots/Videos:
Screenshot from 2023-12-21 11-31-35

If relevant, did you update the documentation?

Summary

Handling Deletion Failure

  • Validate the behavior when organization deletion fails.
  • Confirm that error messages are not displayed.

Closing the Delete Organization Modal

  • Ensure the modal closes when the "Cancel" button is clicked.
  • Verify that the modal is no longer in the document after closure.

Open Delete Organization Modal

  • Confirms component opens the Delete Organization Modal when the "Delete" button is clicked.

Render Delete Button

  • This test ensures that the component correctly renders the Delete button based on specified conditions.

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

yes

palisadoes and others added 30 commits March 8, 2023 07:11
* Initial member page made

* Changed query added Org and Events section

* Homescreen ready

* initial translation added for Profile

* initial translation added for Profile

* Added translations

* Added translations

* Revised translation

* Fixed failing tests for components

* Link added to OrgAdminListCard

* Linting fixed for OrgPeopleListCard

* Added tests, removed logs

* Uniform design
* Fix:routing issue for orgdash page

* fix:failing test of SuperDashListCard
* Feature Request: Position of the search bar PalisadoesFoundation#614 resolved

* Feature Request: Position of the search bar PalisadoesFoundation#614 resolved
PalisadoesFoundation#539)

* Implememnted manage functinality for admin/superadmin after login

* Update AdminDashListCard.module.css

* Some formatting issues with module file

* resolved workflow issues
* added folding feature to posts

* added fold feature to posts

* brought code under code coverage

* added tests

* added tests for remainging uncovered lines

* brought code coverage to 100% for the changes
…sadoesFoundation#530] (PalisadoesFoundation#657)

* fixed updateuser logic

* update translations

* fix lint

* lint fix 2

* fix tests
…on#655)

* fixed:move orgLocation & remove duplicate orgName

* Dummy commit
… styles (PalisadoesFoundation#603)

* fixed: PalisadoesFoundation#585 - Password error showing. Tested

* fix: PalisadoesFoundation#590 - fixed navbar hover issues

* fix: PalisadoesFoundation#590 - fixed navbar hover issues
* fixed errors and removed window.replace

* written test case for ensure window.location.replace

* written test case for ensure window.location.replace

* added useHistory to keep track of routing behind the scenes

* fixed merge conflicts and errors

* updated comments for file changes

* Added warning comments for routing

---------

Co-authored-by: Adepeju <adepeju.kayode@gmail>
…in Calendar (PalisadoesFoundation#527)

* adds tests for organization events

* removes the unrequired branch from OrganizationEvents.tsx

* fixes failing tests

* fixes failing lint tests
* [fix]- fixed the password error warning

* [fix]- fixed the password error warning

* [fix]- fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [fix]-fixed the password error warning

* [feat]-added test cases for password error warning

* [feat]- added test cases for password error warning

* [feat]- added test cases for password error warning

* [fix]- fixed the linting
* Improve test coverage for calendar.tsx

* Restore previous tests

* remove --coverage
palisadoes and others added 27 commits December 7, 2023 04:47
* Feat: Cache npm dependencies

* Add required changes

* Replace with npm ci

* Replace with npm install

* Remove continue_on_error
…#1154)

* feat: updated position of the organization name

* Fix: Prevent content of the org card from being cropped when the organization name is long
…undation#1082)

* requests sorting

* added missing test

* added missing test

* increased test coverage for requests screen

* added the reviewed changes and improved tests
* fixed admin card navigation in dashboard

* removed the use of any
* Fixed overflow of event registrants

* Removed scrollbar
* Update pull-requests.yml

* Update pull-requests.yml
…alisadoesFoundation#1165)

* fix: improve code coverage for src/screens/OrgPost/OrgPost.test.tsx

* fix: improved code coverage for src/components/OrgPostCard/OrgPostCard.tsx
* Added toast on delete action

* Achieved 100% test coverage

* add confirm model and updated the test

* a small commit

* added other language
…#1166)

* Single search modal

* fixes failing test

* updated the test that were failing

* small commit

* fixes test
* Added tests for MemberDetail.tsx

Signed-off-by: bupd <[email protected]>

* Added tests for MemberDetail.tsx

Signed-off-by: bupd <[email protected]>

---------

Signed-off-by: bupd <[email protected]>
* feat: search on enter press

* fixed: test cases for search on enter

* fixed test cases & removed debounce.ts
* Imporved events page

* Minor retriggering commit

* Updated event list design in date

* Added test for changed lines

* Removed unnecessary code and package

* Fixed import
* UI changes in user update page

* Fixed some UI bugs.

* Fix linting checks
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage: Create tests for src/components/DeleteOrg/DeleteOrg.tsx