-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Coverage for DeleteOrg.tsx #1216
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the type errors.
Can you explain a bit on what change you're referring to please? |
Please fix the failing test |
Yes I've found the errors, working on fixing them |
but this issue is not assigned to you? @ShatilKhan |
It was originally assigned to me |
Unfortunately, there isn’t an issue assigned to you for this PR. Please follow the guidelines in our PR_GUIDELINES.md file. We have the procedures in place so that everyone has a fair chance of contributing. I will be closing this pull request. Please follow the procedures and resubmit when ready. We understand the difficulty in your situation but we have to balance dormant issues that get no attention and the need for everyone to get a chance. Please look for or create other issues to work on. Closing |
Fixes #1066
Did you add tests for your changes?
Yes
Summary
Test for Rendering Delete Button
This test checks if the delete button is rendered correctly when the
canDelete
prop istrue
. It renders theDeleteOrg
component and then checks if the delete button (identified by thedata-testid
attributeopenDeleteModalBtn
) is present in the document.Test for Opening Delete Modal
This test checks if the delete modal appears when the delete button is clicked. It renders the
DeleteOrg
component, simulates a click event on the delete button, and then checks if the delete modal (identified by thedata-testid
attributeorgDeleteModal
) is present in the document.Test for Closing Delete Modal
This test checks if the delete modal closes when the close button is clicked. It renders the
DeleteOrg
component, simulates a click event on the delete button to open the modal, simulates another click event on the close button (identified by thedata-testid
attributecloseDelOrgModalBtn
), and then checks if the delete modal is not present in the document.Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes