Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected cancel button functionality #1215

Closed
wants to merge 16 commits into from

Conversation

Anvita0305
Copy link
Contributor

What kind of change does this PR introduce?
Bugfix

Issue Number:
#1211

Did you add tests for your changes?
N/A

Snapshots/Videos:
Screencast from 20-12-23 09:04:25 AM IST.webm

If relevant, did you update the documentation?
N/A

Summary

  1. Corrected cancel button functionality
  2. Fixed button's CSS

Does this PR introduce a breaking change?
No

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make


console.log('clicked!');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please check.

@palisadoes palisadoes requested a review from noman2002 December 21, 2023 05:01
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16de771) 97.34% compared to head (09c1a0b) 97.34%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1215   +/-   ##
========================================
  Coverage    97.34%   97.34%           
========================================
  Files          136      136           
  Lines         3572     3572           
  Branches      1039     1039           
========================================
  Hits          3477     3477           
  Misses          90       90           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the tests for missing lines.

@palisadoes palisadoes requested a review from noman2002 December 25, 2023 13:43
Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests.

@noman2002
Copy link
Member

@Anvita0305 Any update on this ?

@Anvita0305
Copy link
Contributor Author

Will start working this week

@palisadoes
Copy link
Contributor

Please fix the conflicting files

@Anvita0305
Copy link
Contributor Author

fixed conflicting files @palisadoes @noman2002

@palisadoes
Copy link
Contributor

Please fix the conflicting file, it just came up

@palisadoes
Copy link
Contributor

Please review:

@Anvita0305
Copy link
Contributor Author

Can someone please explain why this check is failing as I haven't done any changes to schema.graphql. @noman2002
Screenshot 2024-01-15 023522

@palisadoes
Copy link
Contributor

We discovered a bug in the introspection test. It will be fixed here

@palisadoes
Copy link
Contributor

Reviewers please review this PR. Ignore the failing introspection test for now.

@rishav-jha-mech
Copy link
Contributor

Closing this due to inactivity

@Anvita0305 Anvita0305 deleted the develop2 branch February 9, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants