-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected cancel button functionality #1215
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
||
console.log('clicked!'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, please check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1215 +/- ##
========================================
Coverage 97.34% 97.34%
========================================
Files 136 136
Lines 3572 3572
Branches 1039 1039
========================================
Hits 3477 3477
Misses 90 90
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write the tests for missing lines.
This reverts commit 1320e32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing tests.
@Anvita0305 Any update on this ? |
Will start working this week |
Please fix the conflicting files |
fixed conflicting files @palisadoes @noman2002 |
Please fix the conflicting file, it just came up |
Please review: |
Can someone please explain why this check is failing as I haven't done any changes to schema.graphql. @noman2002 |
We discovered a bug in the introspection test. It will be fixed here |
Reviewers please review this PR. Ignore the failing introspection test for now. |
Closing this due to inactivity |
What kind of change does this PR introduce?
Bugfix
Issue Number:
#1211
Did you add tests for your changes?
N/A
Snapshots/Videos:
Screencast from 20-12-23 09:04:25 AM IST.webm
If relevant, did you update the documentation?
N/A
Summary
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes