Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow for a single object upload for posts #1193

Closed
wants to merge 30 commits into from

Conversation

duplixx
Copy link
Member

@duplixx duplixx commented Dec 13, 2023

What kind of change does this PR introduce?

Issue Number:

Fixes #1127

Did you add tests for your changes?

Snapshots/Videos:

Talawa.Posts.-.Google.Chrome.2023-12-14.00-23-35.mp4

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@duplixx duplixx changed the title Allow for a single object upload for posts Feature: Allow for a single object upload for posts Dec 13, 2023
@duplixx duplixx changed the base branch from main to develop December 13, 2023 19:40
@duplixx duplixx requested a review from palisadoes as a code owner December 13, 2023 19:40
@duplixx duplixx changed the base branch from develop to main December 13, 2023 19:40
@palisadoes palisadoes removed their request for review December 13, 2023 19:44
@duplixx
Copy link
Member Author

duplixx commented Dec 13, 2023

@aashimawadhwa, can you review it and let me know if any changes are required?

@aashimawadhwa
Copy link
Member

can you fix the linting workflow? @duplixx

@palisadoes
Copy link
Contributor

The linting config file has been reverted. Please merge with your upstream and make an updating commit.

@aashimawadhwa
Copy link
Member

@duplixx can you fix the failing test.

@duplixx
Copy link
Member Author

duplixx commented Dec 15, 2023

I'm currently stuck in an error that doesn't make sense. Could you please take a look at it, @aashimawadhwa, @palisadoes, @noman2002? I'll be attaching a video for better understanding.

linting.error.1.2.mp4

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ff2924) 92.77% compared to head (95fdc1a) 92.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   92.77%   92.80%   +0.03%     
==========================================
  Files         134      134              
  Lines        3238     3225      -13     
  Branches      904      897       -7     
==========================================
- Hits         3004     2993      -11     
+ Misses        225      223       -2     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashimawadhwa
Copy link
Member

@duplixx updates?

@duplixx
Copy link
Member Author

duplixx commented Dec 31, 2023

Hi @aashimawadhwa, I am working in it to resolve the issue, but any help will be greatly appreciated.

@rishav-jha-mech
Copy link
Contributor

@duplixx while running tests

./coverage/lcov-report/index.html

run this file on live server, so that you can see which block of code is not being executed/covered by the tests.

Also you while running tests you can use this command,

npm run jest preview

to see how the UI changes, or what effects take place for a particular test. This is the standard way to write tests and debug in talawa-admin.

@duplixx
Copy link
Member Author

duplixx commented Jan 4, 2024

Hey @rishav-jha-mech, I have added multilingual support for text rendering. I'm facing difficulty in implementing test cases for toasters. If you have any hints on how to add test cases for that, it would be helpful.

@rishav-jha-mech
Copy link
Contributor

@duplixx you need to create a mock fn for Toast, go to this file and see how it is implemented, you will get the idea.
src\components\OrgPostCard\OrgPostCard.test.tsx

@duplixx
Copy link
Member Author

duplixx commented Jan 5, 2024

image
image

image

Hi @rishav-jha-mech
I was adding a test case for this line, and the test case I added looks fine, but when I tried running it, it showed an error.

image

@duplixx
Copy link
Member Author

duplixx commented Jan 5, 2024

Hi @rishav-jha-mech,
I've implemented the functionality and made the necessary changes. We can open an issue later to ensure complete test coverage of 100%.

@duplixx duplixx changed the base branch from main to develop January 6, 2024 13:09
@duplixx duplixx changed the base branch from develop to main January 6, 2024 13:09
@rishav-jha-mech
Copy link
Contributor

@duplixx why do you wanna merge into main ?, set the base branch to develop and fix the tests

@duplixx duplixx changed the base branch from main to develop January 13, 2024 15:23
@duplixx
Copy link
Member Author

duplixx commented Jan 13, 2024

@rishav-jha-mech should i open another PR in another branch to fix this ??

@rishav-jha-mech
Copy link
Contributor

@duplixx you can open a new PR for this, keep this PR as a reference to the new one.

@duplixx duplixx changed the base branch from develop to main January 16, 2024 17:28
@noman2002
Copy link
Member

@duplixx Should this be closed ??

@duplixx
Copy link
Member Author

duplixx commented Jan 22, 2024

yeah sure @noman2002

@palisadoes palisadoes closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for a single object upload for posts
6 participants