-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow for a single object upload for posts #1193
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@aashimawadhwa, can you review it and let me know if any changes are required? |
can you fix the linting workflow? @duplixx |
The linting config file has been reverted. Please merge with your upstream and make an updating commit. |
@duplixx can you fix the failing test. |
I'm currently stuck in an error that doesn't make sense. Could you please take a look at it, @aashimawadhwa, @palisadoes, @noman2002? I'll be attaching a video for better understanding. linting.error.1.2.mp4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 92.77% 92.80% +0.03%
==========================================
Files 134 134
Lines 3238 3225 -13
Branches 904 897 -7
==========================================
- Hits 3004 2993 -11
+ Misses 225 223 -2
Partials 9 9 ☔ View full report in Codecov by Sentry. |
@duplixx updates? |
Hi @aashimawadhwa, I am working in it to resolve the issue, but any help will be greatly appreciated. |
@duplixx while running tests ./coverage/lcov-report/index.html run this file on live server, so that you can see which block of code is not being executed/covered by the tests. Also you while running tests you can use this command, npm run jest preview to see how the UI changes, or what effects take place for a particular test. This is the standard way to write tests and debug in talawa-admin. |
Hey @rishav-jha-mech, I have added multilingual support for text rendering. I'm facing difficulty in implementing test cases for toasters. If you have any hints on how to add test cases for that, it would be helpful. |
@duplixx you need to create a mock fn for Toast, go to this file and see how it is implemented, you will get the idea. |
Hi @rishav-jha-mech |
Hi @rishav-jha-mech, |
@duplixx why do you wanna merge into main ?, set the base branch to develop and fix the tests |
@rishav-jha-mech should i open another PR in another branch to fix this ?? |
@duplixx you can open a new PR for this, keep this PR as a reference to the new one. |
@duplixx Should this be closed ?? |
yeah sure @noman2002 |
What kind of change does this PR introduce?
Issue Number:
Fixes #1127
Did you add tests for your changes?
Snapshots/Videos:
Talawa.Posts.-.Google.Chrome.2023-12-14.00-23-35.mp4
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?