-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve code coverage for src/components/EventStats/Statistics/F… #1190
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Recently... a change was made to .eslintrc.json: Due to which the test is failing because it's encountering "any" in many components: The purpose of this pr, which is issue #1036, has been achieved. The coverage is 100%: |
We reverted the culprit PR. Please merge your submitted code with the upstream. |
The app is heavily relying on the ‘any’ type. Since the .eslintrc.json config was set to throw an error upon encountering ‘any’, the test is failing(here). |
@tasneemkoushar Please take a look |
The linting config file has been reverted. Please merge with your upstream and make an updating commit. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1190 +/- ##
===========================================
+ Coverage 95.67% 95.70% +0.02%
===========================================
Files 138 138
Lines 3329 3328 -1
Branches 923 923
===========================================
Hits 3185 3185
+ Misses 138 137 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Alright! All tests have passed. |
What kind of change does this PR introduce?
Improve code coverage
Issue Number:
Fixes #1036
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes