Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve code coverage for src/components/EventStats/Statistics/F… #1190

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

meetulr
Copy link
Contributor

@meetulr meetulr commented Dec 13, 2023

What kind of change does this PR introduce?

Improve code coverage

Issue Number:

Fixes #1036

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@meetulr
Copy link
Contributor Author

meetulr commented Dec 13, 2023

Recently... a change was made to .eslintrc.json:
Screenshot (1)

Due to which the test is failing because it's encountering "any" in many components:
Screenshot (2)

The purpose of this pr, which is issue #1036, has been achieved. The coverage is 100%:
Screenshot (3)

@palisadoes
Copy link
Contributor

We reverted the culprit PR. Please merge your submitted code with the upstream.

@meetulr
Copy link
Contributor Author

meetulr commented Dec 14, 2023

The app is heavily relying on the ‘any’ type. Since the .eslintrc.json config was set to throw an error upon encountering ‘any’, the test is failing(here).

@palisadoes
Copy link
Contributor

@tasneemkoushar Please take a look

@palisadoes
Copy link
Contributor

The linting config file has been reverted. Please merge with your upstream and make an updating commit.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9e7acb) 95.67% compared to head (d5b7d9f) 95.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1190      +/-   ##
===========================================
+ Coverage    95.67%   95.70%   +0.02%     
===========================================
  Files          138      138              
  Lines         3329     3328       -1     
  Branches       923      923              
===========================================
  Hits          3185     3185              
+ Misses         138      137       -1     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meetulr
Copy link
Contributor Author

meetulr commented Dec 15, 2023

Alright! All tests have passed.

@palisadoes palisadoes merged commit 448987d into PalisadoesFoundation:develop Dec 15, 2023
7 checks passed
@meetulr meetulr deleted the develop branch January 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants