fix: Improved events calendar page #1178
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
@pateldivyesh1323
We do this to ensure the overall reliability of the code base is maintained. This is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. |
|
We had to revert a PR that was causing tests to fail incorrectly. Please submit a minor commit to trigger an update of the GitHub workflow |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1178 +/- ##
===========================================
+ Coverage 92.77% 95.55% +2.78%
===========================================
Files 134 137 +3
Lines 3238 3330 +92
Branches 904 931 +27
===========================================
+ Hits 3004 3182 +178
+ Misses 225 142 -83
+ Partials 9 6 -3 ☔ View full report in Codecov by Sentry. |
|
@pateldivyesh1323 the calendar looks good but can we work more on fixed tile sizes and making it visible in a view-port and is this calendar responsive? https://demo.tailadmin.com/calendar |
|
@aashimawadhwa The events will not fit in fixed tile sizes, so I will have to add "more" button to display the events of that date, Is that ok? |
|
Yes please do that on small screen sizes and for the rest show the events as in the tailadmin calendar. |
|
@aashimawadhwa The events are not fitting on single tile on larger screens also, a single tile can handle one or two events not more than that, it will break after it, so should I add "more" button on larger screens similarly? |
this will not accelerate the user experience, please follow the designs as similar to https://demo.tailadmin.com/calendar this demo. |
|
@aashimawadhwa In demo it does shows only single event, but in our case we have multiple events which are not fitting in fixed tile size. |
Screen.Recording.2023-12-12.at.2.46.07.PM.movyou can show 2 events by default in ascending order and then show a more button, to fit 2 events decrease the width of event tile and handle rest case as it is handled in google calendar. @pateldivyesh1323 |
|
@aashimawadhwa Does this look good? Talawa.Events.-.Google.Chrome.2023-12-13.15-35-43.mp4 |
|
@aashimawadhwa I have pushed the latest code There is no use of these file Should I remove them? |
Yes sure you can clean the code. |
|
@aashimawadhwa Done👍 |
|
can you fix this? @pateldivyesh1323 |
|
@aashimawadhwa Done |
palisadoes
merged commit 253f95d
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Improved calendar view of events page
Issue Number:
Fixes #1175
Did you add tests for your changes?
Yes
Snapshots/Videos:
Talawa.Events.-.Google.Chrome.2023-12-11.22-26-15.mp4
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes