-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed admin card navigation in dashboard #1168
Fixed admin card navigation in dashboard #1168
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1168 +/- ##
===========================================
+ Coverage 92.77% 94.71% +1.93%
===========================================
Files 134 138 +4
Lines 3238 3290 +52
Branches 904 913 +9
===========================================
+ Hits 3004 3116 +112
+ Misses 225 167 -58
+ Partials 9 7 -2 ☔ View full report in Codecov by Sentry. |
@aashimawadhwa @noman2002 |
@@ -28,9 +29,12 @@ function organizationPeople(): JSX.Element { | |||
|
|||
document.title = t('title'); | |||
|
|||
const location = useLocation(); | |||
const role = location?.state as any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont use any
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandel-aman you just need to write tests for the changes you have made for now (if required) |
@rishav-jha-mech The changes made in this PR does not require any extra tests to be written. They are already covered in the existing tests. |
LGTM. |
@noman2002 Could please close this issue? The pr for this has been merged. |
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes #1126
Snapshots/Videos:
www_screencapture_com_2023-12-9_04_32.webm
Summary
Earlier on clicking on the admin card the user was navigated to members section in Talawa Members. Fixed the navigation to direct it to admin section in Talawa Members.
Have you read the contributing guide?
Yes