Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed admin card navigation in dashboard #1168

Merged

Conversation

chandel-aman
Copy link
Contributor

What kind of change does this PR introduce?

Bugfix

Issue Number:

Fixes #1126

Snapshots/Videos:

www_screencapture_com_2023-12-9_04_32.webm

Summary

Earlier on clicking on the admin card the user was navigated to members section in Talawa Members. Fixed the navigation to direct it to admin section in Talawa Members.

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Dec 8, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (655b6b3) 92.77% compared to head (f044c97) 94.71%.
Report is 22 commits behind head on develop.

Files Patch % Lines
...rgProfileFieldSettings/OrgProfileFieldSettings.tsx 90.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1168      +/-   ##
===========================================
+ Coverage    92.77%   94.71%   +1.93%     
===========================================
  Files          134      138       +4     
  Lines         3238     3290      +52     
  Branches       904      913       +9     
===========================================
+ Hits          3004     3116     +112     
+ Misses         225      167      -58     
+ Partials         9        7       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chandel-aman
Copy link
Contributor Author

chandel-aman commented Dec 8, 2023

@aashimawadhwa @noman2002
The issue for increasing the test coverage for OrganizationDashboard.tsx is open #1132
So do I need to increase the test coverage too?

@@ -28,9 +29,12 @@ function organizationPeople(): JSX.Element {

document.title = t('title');

const location = useLocation();
const role = location?.state as any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont use any here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
removed the use of any defined interface instead

@rishav-jha-mech
Copy link
Contributor

@chandel-aman you just need to write tests for the changes you have made for now (if required)

@chandel-aman
Copy link
Contributor Author

@rishav-jha-mech The changes made in this PR does not require any extra tests to be written. They are already covered in the existing tests.

@aashimawadhwa
Copy link
Member

LGTM.

@palisadoes palisadoes merged commit dc1f033 into PalisadoesFoundation:develop Dec 9, 2023
6 of 7 checks passed
@chandel-aman
Copy link
Contributor Author

@noman2002 Could please close this issue? The pr for this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants