-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed overflow of event registrants #1164
fix: Fixed overflow of event registrants #1164
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1164 +/- ##
===========================================
+ Coverage 92.77% 94.70% +1.93%
===========================================
Files 134 138 +4
Lines 3238 3288 +50
Branches 904 912 +8
===========================================
+ Hits 3004 3114 +110
+ Misses 225 167 -58
+ Partials 9 7 -2 ☔ View full report in Codecov by Sentry. |
This horizontal scrollbar does not provide a good user experience, I suggest making something like this @pateldivyesh1323 |
Updated |
@aashimawadhwa @rishav-jha-mech please comment |
@palisadoes this can be merged . |
What kind of change does this PR introduce?
Fixed overflow of event registrants in modal
Issue Number:
Fixes #1148
Did you add tests for your changes?
No
Snapshots/Videos:
Before
After
If relevant, did you update the documentation?
No
Summary
Added scrollbar to scroll through the list.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes