Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed overflow of event registrants #1164

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

pateldivyesh1323
Copy link
Contributor

What kind of change does this PR introduce?

Fixed overflow of event registrants in modal

Issue Number:

Fixes #1148

Did you add tests for your changes?

No

Snapshots/Videos:

  • Before
    image

  • After
    image

If relevant, did you update the documentation?

No

Summary

Added scrollbar to scroll through the list.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Dec 8, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (655b6b3) 92.77% compared to head (6c397f6) 94.70%.
Report is 22 commits behind head on develop.

Files Patch % Lines
...rgProfileFieldSettings/OrgProfileFieldSettings.tsx 90.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1164      +/-   ##
===========================================
+ Coverage    92.77%   94.70%   +1.93%     
===========================================
  Files          134      138       +4     
  Lines         3238     3288      +50     
  Branches       904      912       +8     
===========================================
+ Hits          3004     3114     +110     
+ Misses         225      167      -58     
+ Partials         9        7       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashimawadhwa
Copy link
Member

aashimawadhwa commented Dec 8, 2023

This horizontal scrollbar does not provide a good user experience, I suggest making something like this @pateldivyesh1323

Screenshot 2023-12-08 at 10 35 09 PM

@pateldivyesh1323
Copy link
Contributor Author

@aashimawadhwa

Updated

image

@palisadoes
Copy link
Contributor

@aashimawadhwa @rishav-jha-mech please comment

@aashimawadhwa
Copy link
Member

@palisadoes this can be merged .

@palisadoes palisadoes merged commit 0eacfc5 into PalisadoesFoundation:develop Dec 9, 2023
6 of 7 checks passed
@pateldivyesh1323 pateldivyesh1323 deleted the 1148 branch December 9, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants