Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated position of the organization name #1154

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

disha1202
Copy link
Contributor

What kind of change does this PR introduce?
feature

Issue Number:

Fixes #1145

Did you add tests for your changes?
No

Snapshots/Videos:

image

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?
Yes

Copy link

github-actions bot commented Dec 7, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ca2e43) 94.49% compared to head (f23c111) 94.49%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1154   +/-   ##
========================================
  Coverage    94.49%   94.49%           
========================================
  Files          138      138           
  Lines         3286     3286           
  Branches       912      912           
========================================
  Hits          3105     3105           
  Misses         174      174           
  Partials         7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

noman2002
noman2002 previously approved these changes Dec 8, 2023
@disha1202
Copy link
Contributor Author

Hi @noman2002

I was testing all possible scenarios, and came across this issue.

If the name of the organization is long, the content of the organization card is cropped.

image

I can think of three possible solutions.

  1. We can have a character limit for organization name.
  2. We can add ellipsis and display the whole name in a tooltip.
    image
  3. We can adjust the height of the card as per the content.
image

What do you think?

@noman2002
Copy link
Member

noman2002 commented Dec 8, 2023

@disha1202 I think adjusting the card height as per content is a better approach or may be ellipsis will work too. We cannot have a limit on the name of organization.

@disha1202
Copy link
Contributor Author

@disha1202 I think adjusting the card height as per content is a better approach or may be ellipsis will work too. We cannot have a limit on the name of organization.

I agree, also I think the ellipsis would be a better option as adjusting the card height as per content will lead to inconsistency in the UI.

@noman2002
Copy link
Member

@disha1202 I think adjusting the card height as per content is a better approach or may be ellipsis will work too. We cannot have a limit on the name of organization.

I agree, also I think the ellipsis would be a better option as adjusting the card height as per content will lead to inconsistency in the UI.

Okay, please go ahead with the ellipsis approach.

@disha1202
Copy link
Contributor Author

disha1202 commented Dec 8, 2023

Fixed content of the org card being cropped when the organization name is long

Screenshot 2023-12-08 at 12 57 00 PM

@palisadoes palisadoes merged commit 64f3ab3 into PalisadoesFoundation:develop Dec 8, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants