-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and optimized Home.test.tsx #1147
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linting errors.
@noman2002 thank you sir for pointing me out , I will not repeat it next time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1147 +/- ##
========================================
Coverage 94.49% 94.49%
========================================
Files 138 138
Lines 3286 3286
Branches 912 912
========================================
Hits 3105 3105
Misses 174 174
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Why hasn't the code coverage increased in this PR? The issue was created to increase it to 100%. Please let us know. |
The test code coverage is dropping significantly with this PR. Please get to at least 95% coverage for all your edited files. Though there may be issues to increase the coverage for the file, the aim is for them to reach 100% coverage Please post the screenshot with your coverage when complete |
@vivekBoii are you still working on this? |
I am closing this as there hasn't been any activity in 3 weeks. |
What kind of change does this PR introduce?
Update and optimization of code
Issue Number:
Fixes #1131
Did you add tests for your changes?
This is unittest itself
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Update and optimization of code in Home.test.tsx
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes