-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
achieved test coverage for OrgListCard.tsx #1141
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
+ Coverage 93.63% 94.27% +0.64%
===========================================
Files 129 138 +9
Lines 3096 3286 +190
Branches 883 912 +29
===========================================
+ Hits 2899 3098 +199
+ Misses 190 181 -9
Partials 7 7 ☔ View full report in Codecov by Sentry. |
@Min2who This PR seems not to have achieve its goal. The Code coverage is 95% though you posted coverage of 100% in the comments. You also removed your assignment from the issue after assignment. I'm going to revert this PR. This is not in keeping with the spirit of our organization. |
This reverts commit 58322cd.
What kind of change does this PR introduce?
Issue Number:
Fixes #1067
Did you add tests for your changes?
Yes
Snapshots/Videos:
Summary
This PR achieved the 100% test coverage of src/components/OrgListCard/OrgListCard.tsx
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes