Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

achieved test coverage for OrgListCard.tsx #1141

Merged
merged 1 commit into from
Dec 7, 2023
Merged

achieved test coverage for OrgListCard.tsx #1141

merged 1 commit into from
Dec 7, 2023

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Dec 6, 2023

What kind of change does this PR introduce?

Issue Number:

Fixes #1067

Did you add tests for your changes?

Yes

Snapshots/Videos:

Screenshot 2023-12-06 205005

Summary

This PR achieved the 100% test coverage of src/components/OrgListCard/OrgListCard.tsx

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Dec 6, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61cd635) 93.63% compared to head (1435122) 94.27%.
Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1141      +/-   ##
===========================================
+ Coverage    93.63%   94.27%   +0.64%     
===========================================
  Files          129      138       +9     
  Lines         3096     3286     +190     
  Branches       883      912      +29     
===========================================
+ Hits          2899     3098     +199     
+ Misses         190      181       -9     
  Partials         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 58322cd into PalisadoesFoundation:develop Dec 7, 2023
7 of 8 checks passed
@palisadoes
Copy link
Contributor

@Min2who This PR seems not to have achieve its goal. The Code coverage is 95% though you posted coverage of 100% in the comments. You also removed your assignment from the issue after assignment.

I'm going to revert this PR. This is not in keeping with the spirit of our organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants