Added Pinning functionality in the create post modal. #1129
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
palisadoes
requested review from
aashimawadhwa and
rishav-jha-mech
and removed request for
aashimawadhwa
|
@AmitSharma512 Please get the code coverage for the file you edited up to 100%. That is the cause of the failed tests. |
There was a problem hiding this comment.
@AmitSharma512 Please get the code coverage for the file you edited up to 100%. That is the cause of the failed tests.
I updated the code and added tests for the same. |
|
@aashimawadhwa I have updated the code and added tests for the same, plz review it. |
… into Pinned-post'
|
@AmitSharma512 Please attach a screenshot of 100% code coverage of file you edited. |
I have added the test for the modified files |
only those lines are left which are not updated by me. |
You have to write the test for all the missing lines in a file which you edit. Please add the tests for missing lines and get it to 100% |
I have written test for all the missing lines, this screenshot is showing the current code coverage. |
… into Pinned-post'
This is still showing 95% , please get it to 100%. |
… into Pinned-post'
|
@aashimawadhwa i have made the required changes and written the tests for the same also, plz review it. |
|
The test code coverage is dropping significantly with this PR. Please get to at least 95% coverage for all your edited files. Though there may be issues to increase the coverage for the file, the aim is for them to reach 100% coverage |
|
@palisadoes after getting all the files covered, the percentage will still be 94.46% as the previous code, without any changes is also not above 95 percent. |
|
Please try merging your code in this PR with the latest upstream. That should fix it. |
… into Pinned-post'
|
@palisadoes now the test coverage is 95.43% which is above 95% |
|
The patch is still only 80% according to the last set of tests. Please fix.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1129 +/- ##
===========================================
- Coverage 95.46% 95.43% -0.03%
===========================================
Files 138 138
Lines 3328 3333 +5
Branches 923 923
===========================================
+ Hits 3177 3181 +4
- Misses 144 145 +1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
There is some minor work that needs to be done to get is to the desired 100% test coverage on this file. Please try to get us there. The reliability of our code is very important |
|
Is this still being worked on? |
|
@palisadoes yes |
|
@AmitSharma512 Its been more than 3 weeks since this PR is open. Please update on this or I have to close it. |
|
Closing due to inactivity. |
What kind of change does this PR introduce?
Pinning functionality in the create post modal.
Issue Number:
Fixes #1122
Summary
I added the pinning functionality in the create post modal to pin the post in the create post modal itself.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes