-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1123] Changes position and text of "All Organizations" button #1124
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Please share a screenshot and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing test.
Ok will work on it! |
The coverage is dropping significantly. Please get the coverage to 100% for the files you edited and merge the latest code into this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
=======================================
Coverage 92.77% 92.77%
=======================================
Files 134 134
Lines 3238 3238
Branches 904 904
=======================================
Hits 3004 3004
Misses 225 225
Partials 9 9 ☔ View full report in Codecov by Sentry. |
@aashimawadhwa @beingnoble03 The coverage is down because of files which are not under the scope of this pull request and issue, what should I do from here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the mentioned unnecessary changes.
@noman2002 we can merge this |
@palisadoes this can be merged |
@noman2002 please review. We can't merge until you have dismissed your previous requests for change. |
@adi790uu Need to revert this. This should be develop branch not on main. |
What kind of change does this PR introduce?
This PR renames the "All Organizations" button to "My Organizations" and fixes its postion as specified in the issue.
Issue Number:
Fixes #1123
Did you add tests for your changes?
No
Snapshots/Videos:
Screencast.from.05-12-23.03.14.37.PM.IST.webm
If relevant, did you update the documentation?
No
Summary
This pull request addresses the specified issue by renaming the "All Organizations" button to "My Organizations" and adjusting its position to enhance the UI/UX.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes