Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1123] Changes position and text of "All Organizations" button #1124

Merged
merged 5 commits into from
Dec 10, 2023
Merged

[#1123] Changes position and text of "All Organizations" button #1124

merged 5 commits into from
Dec 10, 2023

Conversation

adi790uu
Copy link
Contributor

@adi790uu adi790uu commented Dec 5, 2023

What kind of change does this PR introduce?

This PR renames the "All Organizations" button to "My Organizations" and fixes its postion as specified in the issue.

Issue Number:

Fixes #1123

Did you add tests for your changes?

No

Snapshots/Videos:

Screencast.from.05-12-23.03.14.37.PM.IST.webm

If relevant, did you update the documentation?

No

Summary

This pull request addresses the specified issue by renaming the "All Organizations" button to "My Organizations" and adjusting its position to enhance the UI/UX.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

github-actions bot commented Dec 5, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@aashimawadhwa
Copy link
Member

aashimawadhwa commented Dec 5, 2023

Please share a screenshot and
Please make the code coverage 100% for the modified file. It has been declining overall and we need to make sure we get it back up to make our code more stable.
@adi790uu
also make changes in the locales file as well.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test.

@adi790uu
Copy link
Contributor Author

adi790uu commented Dec 5, 2023

Ok will work on it!

@noman2002
Copy link
Member

The coverage is dropping significantly. Please get the coverage to 100% for the files you edited and merge the latest code into this PR.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f71bc11) 92.77% compared to head (dd2c89d) 92.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         134      134           
  Lines        3238     3238           
  Branches      904      904           
=======================================
  Hits         3004     3004           
  Misses        225      225           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adi790uu
Copy link
Contributor Author

adi790uu commented Dec 7, 2023

@aashimawadhwa @beingnoble03 The coverage is down because of files which are not under the scope of this pull request and issue, what should I do from here?

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the mentioned unnecessary changes.

src/GraphQl/Queries/Queries.ts Outdated Show resolved Hide resolved
@aashimawadhwa
Copy link
Member

@noman2002 we can merge this

@aashimawadhwa
Copy link
Member

@palisadoes this can be merged

@palisadoes palisadoes requested a review from noman2002 December 9, 2023 16:31
@palisadoes
Copy link
Contributor

@noman2002 please review. We can't merge until you have dismissed your previous requests for change.

@noman2002 noman2002 merged commit 1fd4105 into PalisadoesFoundation:main Dec 10, 2023
6 of 7 checks passed
noman2002 added a commit that referenced this pull request Dec 12, 2023
@noman2002
Copy link
Member

@adi790uu Need to revert this. This should be develop branch not on main.

noman2002 added a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix in position and text of all organization button
5 participants