Fixed the Toast message and changed the routing for DeleteOrg page. #1114
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1114 +/- ##
========================================
Coverage 94.21% 94.21%
========================================
Files 138 138
Lines 3282 3283 +1
Branches 912 912
========================================
+ Hits 3092 3093 +1
Misses 183 183
Partials 7 7 ☔ View full report in Codecov by Sentry. |
| try { | ||
| await removeSampleOrganization(); | ||
| toast.success('Successfully deleted sample Organization'); | ||
| history.push('/orglist'); | ||
| } catch (error: any) { | ||
| toast.error(error.message); | ||
| } |
There was a problem hiding this comment.
Please write the test for these lines.
There was a problem hiding this comment.
I tried to write the tests, but every time I got an unexpected error that I was not able to solve.
According to my knowledge, my basics are correct but then also tests are not passing.
| toast.success('Successfully deleted Organization'); | ||
| history.push('/orglist'); |
There was a problem hiding this comment.
Please write the test for these lines.
What kind of change does this PR introduce?
This PR solves the issue of the toast message not being displayed while deleting the organization.
Issue Number:
Fixes #1108
Did you add tests for your changes?
No
Snapshots/Videos:
After Fixing the issue :
After.fix.mp4
Summary
Previously, When we delete an organization or a sample organization, no toast message of success was shown, and instead of using React Routing, window.location.replace was used. This PR solves the all above issues.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes