Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Frontend now reflects advertisement deletion, aligning with backend. #1113

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

aialok
Copy link
Contributor

@aialok aialok commented Dec 2, 2023

What kind of change does this PR introduce?

  • Before
    • Upon deleting the advertisement, it is expected to be removed from the backend and no longer displayed on the frontend. However, despite deletion on the backend, the advertisement continues to appear on the frontend.
  • After
    • Now Deletion will reflect to both frontend and backend

Issue Number:

Fixes #1109

Did you add tests for your changes?

  • No

Snapshots/Videos:

  • Before
Delete_Bug.webm
  • After
Fixes_Delete_bug.webm

If relevant, did you update the documentation?

Summary

  • Now when user will delete the advertisement it will refelect to frontend as well.

Does this PR introduce a breaking change?

  • No

Other information

Have you read the contributing guide?

  • Yes

Copy link

github-actions bot commented Dec 2, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da35be1) 0.00% compared to head (8deadac) 93.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1113       +/-   ##
============================================
+ Coverage         0   93.54%   +93.54%     
============================================
  Files            0      138      +138     
  Lines            0     3285     +3285     
  Branches         0      913      +913     
============================================
+ Hits             0     3073     +3073     
- Misses           0      205      +205     
- Partials         0        7        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit f61b79e into PalisadoesFoundation:develop Dec 2, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants