-
-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test for LeftDrawerEventWrapper.tsx to 100% coverage #1103
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1103 +/- ##
===========================================
+ Coverage 92.77% 92.80% +0.03%
===========================================
Files 134 134
Lines 3238 3238
Branches 904 904
===========================================
+ Hits 3004 3005 +1
+ Misses 225 224 -1
Partials 9 9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @timoph2
Update test for LeftDrawerEventWrapper.tsx to 100% coverage.
Fixes #1033
Summary
Added tests which covers line 40, where pageContainer was not previously tested for 'expand' or 'contract' class.
Does this PR introduce a breaking change?
No
Other information
Chose to use Regex because pageContainer classes somehow had extra suffix added in like "_pageContainer_1k3kw_1" which .toHaveClass method cannot assert properly.
Have you read the contributing guide?
Yes