Added Docker file for the projects #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heyjordn @palisadoes Sir it is ready to be merged |
palisadoes
requested changes
Apr 24, 2021
There was a problem hiding this comment.
@yasharth291 We'll need documentation for this. No one will know this functionality exists. Add it to the installation file to ensure this feature is used.
|
adding documentation sir |
|
@palisadoes sir i have added the way to use docker |
|
@palisadoes sir if you can merge this i have another pr ready to be merged |
palisadoes
reviewed
Apr 26, 2021
palisadoes
requested changes
Apr 26, 2021
|
sure sir |
|
@palisadoes done sir |
palisadoes
requested changes
Apr 27, 2021
|
Provide links on how to install docker on the system. |
|
sure sir adding what is asked
…On Tue, Apr 27, 2021, 9:22 AM Peter Harrison ***@***.***> wrote:
Provide links on how to install docker on the system.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDU3TKWNBQOPPUIH4YKTQTTKYYITANCNFSM42LSUZ4A>
.
|
|
@palisadoes sir i have added everything in the pr please review it @DangaRanga @heyjordn |
palisadoes
requested review from
DangaRanga,
heyjordn and
palisadoes
and removed request for
palisadoes
DangaRanga
requested changes
Apr 30, 2021
|
@DangaRanga done sir now you can merge this |
DangaRanga
requested changes
Apr 30, 2021
DangaRanga
approved these changes
Apr 30, 2021
This reverts commit c506e79.
|
@palisadoes @DangaRanga could you please merge it if it is right |
palisadoes
requested changes
May 3, 2021
|
@palisadoes sir it is resolved please merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Docker files for the Project to run inside a docker container
Fixes #1