Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package react-i18next from 11.18.6 to 12.3.1 #2096

Closed
palisadoes opened this issue Jul 15, 2024 · 8 comments
Closed

Upgrade package react-i18next from 11.18.6 to 12.3.1 #2096

palisadoes opened this issue Jul 15, 2024 · 8 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade react-i18next from 11.18.6 to 12.3.1.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps react-i18next from 11.18.6 to 12.3.1.

Changelog

Sourced from react-i18next's changelog.

12.3.1

  • optimization for optional lng prop for useTranslation, should now prevent missings when lazy loading translations 1637

12.3.0

  • optional lng prop for useTranslation (helping on server side 1637)

12.2.2

  • try to fix conditional exports in package.json

12.2.1

  • type fix: the type of defaultNS in I18nextProvider should support string[] 1633

12.2.0

  • if defaultValue is passed in not ready t functio (via useTranslation) return that instead of the key, even though the user-land could should be fixed 1618

12.1.5

  • fix react merged types 1606 originally introduced with #1531 to address #1506

12.1.4

  • fix crash in gatsby 1594

12.1.3

  • fix fallback of t function in Trans component

12.1.2

  • fix crash in gatsby 1594

12.1.1

  • fix for node resolution 1589

12.1.0

  • context-less version of Trans component to be used for environments without react context 1588

12.0.0

  • Update t function types to rely on types coming from i18next 1501
Commits
  • f0a83cc 12.3.1
  • 034e13e optimization for optional lng prop for useTranslation, should now prevent mis...
  • 6dd1056 12.3.0
  • 1019f88 optional lng prop for useTranslation #1637
  • dbe2d0e 12.2.2
  • b74ffdf try to fix conditional exports in package.json #1634
  • 787b2f9 12.2.1
  • e0c7854 type fix: the type of defaultNS in I18nextProvider should support string[]
  • 807182d fix: the type of defaultNS in I18nextProvider should support string[] (...
  • 7026d54 update test-jest for react 18
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added the bug Something isn't working label Jul 15, 2024
@github-actions github-actions bot added security Security fix test Testing application unapproved labels Jul 15, 2024
@palisadoes palisadoes added good first issue Good for newcomers dependencies Pull requests that update a dependency file and removed unapproved test Testing application labels Jul 15, 2024
@Apocalypse96
Copy link

I would love to solve this issue @palisadoes pls assign this to me

@dhanagopu dhanagopu removed the good first issue Good for newcomers label Jul 17, 2024
@Apocalypse96 Apocalypse96 removed their assignment Jul 20, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added no-issue-activity No issue activity and removed no-issue-activity No issue activity labels Jul 31, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 11, 2024
@ManjariRathore
Copy link
Contributor

ManjariRathore commented Aug 12, 2024

Hello @palisadoes, @varshith257

I would like to work on this issue, if possible can you assign this to me. I will raise a draft PR asap.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 24, 2024
@Suswetha6
Copy link
Contributor

Hello @palisadoes, @varshith257

I would like to work on this issue

@varshith257 varshith257 removed the no-issue-activity No issue activity label Aug 26, 2024
@varshith257
Copy link
Member

@Suswetha6 Here you go 🚀

If you encounter any problems regarding solving this issue or any feel free to reach us in Slack.

@Suswetha6
Copy link
Contributor

He @varshith257 @palisadoes , please review my pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix
Projects
None yet
Development

No branches or pull requests

6 participants