Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add membership request feature for ADMIN #1416

Closed
Shubh152 opened this issue Jan 10, 2024 · 23 comments
Closed

Add membership request feature for ADMIN #1416

Shubh152 opened this issue Jan 10, 2024 · 23 comments
Assignees
Labels

Comments

@Shubh152
Copy link
Contributor

Shubh152 commented Jan 10, 2024

Is your feature request related to a problem? Please describe.
Currently, there is no interface for handling the membership join request feature as an ADMIN. There is only the coming soon toast or a redirect to the home page for ADMIN.

Describe the solution you'd like
Display the membership requests in a list form with options to either accept or reject their request with a Request ID and the organization name they want to join.

Describe alternatives you've considered
On clicking a user profile in the membership request section, a popup should appear showing information about the user like when they joined the platform or what organisation they are a part of to verify their identity.

Approach to be followed (optional)

Additional context

issue.mp4

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@Shubh152
Copy link
Contributor Author

If this is a valid issue, please assign to me.

@dhruvgupta0503
Copy link

Hi, Can I pls work on this issue

@nitishkumar333
Copy link
Contributor

same as #1400

@Shubh152
Copy link
Contributor Author

This issue will provide a UI to manage membership requests from USERS on the ADMIN panel. #1440 provides membership request feature on USER panel.

@rishav-jha-mech is this feature needed?

@shahzamaahmad
Copy link

Can you assign it to me.

@Cioppolo14
Copy link
Contributor

Sorry, I got a little ahead of myself with this issue. @Shubh152 Please present a design for this issue, thank you for submitting it.

@shahzamaahmad
Copy link

@Cioppolo14 why unassigned?

@palisadoes
Copy link
Contributor

@Shubh152

This supporting issue has been created.

@Cioppolo14
Copy link
Contributor

@shahzamaahmad I thought it was a different issue and realize I needed feedback. Our rules are to assign the first person who requested to work on the issue who doesn't already have 2 issues. I got a little ahead of myself and needed to get some feedback and review all the comments before assigning. Sorry about the confusion.

@palisadoes
Copy link
Contributor

@Shubh152

  1. Be aware that these issues have been created
    1. API - Select organization on registration talawa-api#1703
    2. Mobile - Select organization on registration talawa#2330
    3. Admin - Select organization on registration #1440
  2. Refer to the design document on the required layout. The menu item highlighted in red needs to be moved to the Admin screen for the organization
    1. https://docs.talawa.io/docs/design/ux/ux-design-system
      image
  3. This is where the menu button needs to be moved:
    image

@palisadoes
Copy link
Contributor

@Shubh152

Please refer to this thread to get an idea of what is coming and the rationale for this issue.

Copy link

github-actions bot commented Feb 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 1, 2024
@palisadoes
Copy link
Contributor

Unassigning. No activity

@Shubh152
Copy link
Contributor Author

Shubh152 commented Feb 1, 2024

Please reassign .Currently working on it. Will Submit a PR within few days.

@Shubh152
Copy link
Contributor Author

Shubh152 commented Feb 1, 2024

Also wanted to point out that currently there is no way to join a organization from the user web portal. Is this planned?

@palisadoes
Copy link
Contributor

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 2, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 12, 2024
@Shubh152
Copy link
Contributor Author

The changes are ready and PR will be made after my current PR gets reviewed.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 13, 2024
@aashimawadhwa
Copy link
Member

@Shubh152
we are closing this issue for now under the unplanned category, we appreciate your work and presence on this. we will make concise and clear designs for this issue and reopen a new one soon.

thanks.

@Shubh152
Copy link
Contributor Author

No problem. I will keep the changes stashed in case the issue reopens.

@Shubh152
Copy link
Contributor Author

@aashimawadhwa Is this closing or plan is changed?

Copy link

github-actions bot commented Mar 3, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 3, 2024
@Cioppolo14
Copy link
Contributor

I believe this issue was supposed to be closed, so I am closing now.

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants