Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Deprecate Titles for Non-Pinned Posts #1486

Closed
palisadoes opened this issue Jan 24, 2024 · 31 comments
Closed

Admin: Deprecate Titles for Non-Pinned Posts #1486

palisadoes opened this issue Jan 24, 2024 · 31 comments
Labels

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2024

Is your feature request related to a problem? Please describe.

Our post feature has never worked as expected. The original idea was for only pinned posts created by Admins requiring titles to attract greater attention, all other posts would not have them.

Social media platforms do not require titles for news feed posts, this is because it adds a step that increases the risk of low interaction rates. We need to implement this as per the original design.

Describe the solution you'd like

API

  1. The API must only require titles for pinned posts. All other post types must generate an appropriate error if a title is provided.
  2. Pinned posts can only be created by Super Admins or Admins for the organization where the post was created

Admin

  1. Only pinned posts must require titles.
  2. Non Pinned Posts
    1. Post screens not related to pinned posts must not display titles (As they won’t exist)
  3. There must be no CRUD activity related the titles of regular post
  4. Pinned posts can only be created by Super Admins or Admins for the organization where the post was created

Mobile

  1. The mobile app must not allow the creation of pinned posts as this is an Admin function
  2. There must be no CRUD activity related the titles of regular post
  3. Pinned posts can only be created by Super Admins or Admins for the organization where the post was created

Other

  1. All tests for this functionality update must be valid
  2. No other functionality must be altered

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • N/A

Additional context

Related issues:

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Sejal1411
Copy link

Would like to contribute to this issue. Pls assign!

@pateldivyesh1323
Copy link
Contributor

I would like to work on this.

@Abhinob-Bora
Copy link

Abhinob-Bora commented Jan 25, 2024

@palisadoes @Cioppolo14 Can you please explain whether i can work on the desktop (admin) page currently as i havent done the setup for the mobile or i have to raise a PR solving both mobile and admin posts?

@palisadoes
Copy link
Contributor Author

The API work is complete. You can start on your work

@Abhinob-Bora
Copy link

Ok thanks

@Sejal1411
Copy link

Hey @palisadoes I am unable to view Pin feature here even after fetching data from upstream..

Screenshot 2024-01-25 112315

@palisadoes
Copy link
Contributor Author

@pateldivyesh1323 Your recently merged PR is negatively impacting the pinned post feature. Please work with @Sejal1411 on this. Create a new PR on the same API issue if necessary.

@Abhinob-Bora
Copy link

Abhinob-Bora commented Jan 28, 2024

@palisadoes can you please clarify one thing...

every post will have a title input right ( title input box should be there for ADMIN OR SUPER ADMIN )

And whenever a ADMIN or SUPER ADMIN clicks on PIN POST the post should show the title.Else it shouldn't show the title

For users the post shouldn't even have the input title box.

Am I correct!?

@Sejal1411
Copy link

@Abhinob-Bora are u working on this issue?

@Abhinob-Bora
Copy link

@Abhinob-Bora are u working on this issue?

Yes

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 28, 2024

@Abhinob-Bora are u working on this issue?

Yes

@Abhinob-Bora

You are not assigned this issue. If you submit a PR with no matching issue to which you are assigned, it will be closed. Please work on issues to which you are assigned.

@Abhinob-Bora
Copy link

Oh ok

@Abhinob-Bora are u working on this issue?

Yes

@Abhinob-Bora

You are not assigned this issue. If you submit a PR with no matching issue to which you are assigned, it will be closed. Please work on issues to which you are assigned.

Oh ok thanks for the updates....

@palisadoes
Copy link
Contributor Author

Oh ok

@Abhinob-Bora are u working on this issue?

Yes

@Abhinob-Bora
You are not assigned this issue. If you submit a PR with no matching issue to which you are assigned, it will be closed. Please work on issues to which you are assigned.

Oh ok thanks for the updates....

Please watch all the videos in our playlist

https://www.youtube.com/watch?v=iYdyBfXdV2w&list=PLv50qHwThlJUIzscg9a80a9-HmAlmUdCF&index=5

@Abhinob-Bora
Copy link

Oh ok

@Abhinob-Bora are u working on this issue?

Yes

@Abhinob-Bora
You are not assigned this issue. If you submit a PR with no matching issue to which you are assigned, it will be closed. Please work on issues to which you are assigned.

Oh ok thanks for the updates....

Please watch all the videos in our playlist

https://www.youtube.com/watch?v=iYdyBfXdV2w&list=PLv50qHwThlJUIzscg9a80a9-HmAlmUdCF&index=5

Ok got it

@Sejal1411
Copy link

Would the regular posts be non-pinned posts? @palisadoes

@palisadoes
Copy link
Contributor Author

Yes. They don't have the flag set

@Sejal1411
Copy link

I will open the PR in 2-3 days. Pls do not unassign!

@Sejal1411
Copy link

@palisadoes I have added the code changes for the following feature. Do i have to write tests for the same?

Recording.2024-02-15.195521.mp4

@palisadoes
Copy link
Contributor Author

Always

1 similar comment
@palisadoes
Copy link
Contributor Author

Always

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 26, 2024
@Cioppolo14
Copy link
Contributor

Unassigning, I do not see an open PR and there has been no activity.

@pateldivyesh1323
Copy link
Contributor

@Cioppolo14 I would like to work on this.

Copy link

github-actions bot commented Mar 8, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 8, 2024
@Cioppolo14
Copy link
Contributor

Unassigning due to no activity or open PR.

@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Mar 8, 2024
@lakshz
Copy link
Contributor

lakshz commented Mar 10, 2024

Hey, can I work on this?

@Cioppolo14
Copy link
Contributor

@lakshz Thank you for your willingness to contribute. Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. We will get your PRs reviewed soon.

@Anvita0305
Copy link
Contributor

Hello, can I work on this?

Copy link

github-actions bot commented Apr 6, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 6, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Apr 6, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 17, 2024
Copy link

This issue did not get any activity in the past 180 days and thus has been closed. Please check if the newest release or develop branch has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants