Admin: GitHub Action Required: Fail on detection of eslint-ignore statements

[palisadoes]

Is your feature request related to a problem? Please describe.

The quality of our code is paramount to us. This includes:

1. Functionality
2. Consistency of coding style for improved readability
3. Following best practice coding standards

To achieve the last 2 points, we have been gradually increasing the linting rules enforced in the repository to maintain a consistency of our code style. We have implemented githooks to try to enforce this linting best practice.

Even so, we have seen contributors adding statements to ignore our linting rules.

Describe the solution you'd like

1. Remove the typescript linting ignore statements to reveal the original linting errors
2. Fix the causes of the linting errors without affecting functionality
3. Add a test to our pull request GitHub action file to fail if any files submitted in the PR:
   1. under the src/ directory have ignore statements
   2. the setup.ts script in the root directory
4. There may be cases in test files where linting is required, but this should not be the case in non-test typescript files.
5. The GitHub action file is:
   1. https://github.com/PalisadoesFoundation/talawa-admin/blob/develop/.github/workflows/pull-requests.yml

Describe alternatives you've considered

• N/A

Approach to be followed (optional)

• N/A

Additional context

• Evidence of the use of the ignore statements in the src/ directory

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

• Student Internship Programs talawa#359

[ParishiB]

@palisadoes assign me please

[Sauradip07]

@palisadoes please assign this issue to me

[takshakmudgal]

I'd really like to work on this issue, I haven't really been assigned to a issue lately and am really waiting to get my contributions in.

[Cioppolo14]

@takshakmudgal Please keep your eye on the issues! We will find you one. Our policy is to assign the first person to ask who has less than 2 issues across the repos. Thank you!

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[Cioppolo14]

@ParishiB Are you still working on this?

[ParishiB]

yes , i am working on it. will close it soon

[palisadoes]

@ParishiB

When do you think you'll be able to submit a PR for this? It's an important code quality issue that needs to be resolved.

[ParishiB]

yes , i am doing it , just facing issue with react indent , it is taking time fixng the lint v/s prettier issue.Any advice would be appreciated

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[palisadoes]

Unassigning due to inactivity

[techmannih]

I want to work on this issue. Assign me

[techmannih]

I want to work on this issue, assign me

[aarishshahmohsin]

Can I be assigned this issue?

[aarishshahmohsin]

@palisadoes @Olatade please review this PR or close it.

[palisadoes]

@aarishshahmohsin Thanks for the reminder. It's been merged.