-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Linting Only to Files Updated in git
#1270
Labels
Comments
palisadoes
changed the title
Apply Linting Only to Updated Files
Apply Linting Only to Files Updated in Dec 23, 2023
git
Please assign this issue to me |
This was referenced Dec 29, 2023
@Nitya-Pasrija Please be aware of this issue |
Will look into it |
@Cioppolo14 I would like to work on this issue. |
@Veer0x1 If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance. |
|
I'm going to open another issue to finish the job so that someone else can get a chance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need the ability to selectively adjust our linting rules so that they are eventually applied to our entire code base.
.eslintrc.json
file.warn
toerror
then every file in the code base will be checked and we have frequently seen our tests fail for dozens of files in hundreds of lines of code.This is not acceptable.
We have been trying to more strictly lint the entire code base manually, but it has been very slow.
At the user CLI
We need a way to edit
.eslintrc.json
with increasingly stricter linting rules in such a way that the tests are only applied to the changed files with everygit commit
andgit push
command.These
git
commands must fail if the linting fails.With Every Pull Request
We recently merged a Talawa-API pull request that checks each submitted file for linting compliance. This can be used as an example of how to run the test against individual files.
You must make sure that this functionality applied for all PRs for this repository whenever the
.eslintrc.json
file is updatedOther
git
talawa-api#1548Screenshots
When complete, you should be able to convert all these
.eslintrc.json
file lines containingwarn
toerror
and the tests will only be applied to the changed files ingit
The text was updated successfully, but these errors were encountered: