Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App must run without using npm install --legacy-peer-deps #1246

Closed
palisadoes opened this issue Dec 22, 2023 · 7 comments
Closed

App must run without using npm install --legacy-peer-deps #1246

palisadoes opened this issue Dec 22, 2023 · 7 comments
Assignees
Labels
dependencies Pull requests that update a dependency file feature request no-issue-activity No issue activity

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. The app depends on legacy dependencies
  2. The app must be upgraded to not use --legacy-peer-deps

Describe the solution you'd like

  1. Upgrade app packages to not require the --legacy-peer-deps qualifier when running npm install
  2. Update the INSTALLATION.md file with the new installation process just using npm install
  3. The npm install must not redirect to npm install --legacy-peer-deps in any hidden way.
  4. npm install --legacy-peer-deps must not be invoked in any way behind the scenes to install the latest required packages
  5. All existing tests must pass
  6. No functionality must be removed

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  • N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@palisadoes palisadoes changed the title App should run without using npm install --legacy-peer-deps App must run without using npm install --legacy-peer-deps Dec 22, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file unapproved labels Dec 22, 2023
@git-init-priyanshu
Copy link
Member

I would like to work on this issue.

@dhiraj0911
Copy link
Contributor

Hey I'd like to work on this issue too

@git-init-priyanshu
Copy link
Member

Hey @palisadoes, I have fixed the issue by uninstalling the package enzyme-adapter-react-16 and using @wojtekmaj/enzyme-adapter-react-17 (which was already installed and correctly used in place of the previously mentioned package). I am no longer getting errors with peer dependency, but I am receiving several warnings. Should I also resolve those warnings?
image
image

@palisadoes
Copy link
Contributor Author

Yes. There should be no warnings. We should not be using deprecated or outdated packages. Open a PR when done

@palisadoes
Copy link
Contributor Author

Also, determine the latest version of node that the app will work with and add it to the INSTALLATION.md file under the node installation section.

We need to state what our recommended version of node should be

@git-init-priyanshu
Copy link
Member

Got it

Copy link

github-actions bot commented Jan 3, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature request no-issue-activity No issue activity
Projects
None yet
Development

No branches or pull requests

4 participants