Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling media support to the create ad action #1158

Closed
aashimawadhwa opened this issue Dec 7, 2023 · 5 comments
Closed

Enabling media support to the create ad action #1158

aashimawadhwa opened this issue Dec 7, 2023 · 5 comments
Assignees
Labels

Comments

@aashimawadhwa
Copy link
Member

Is your feature request related to a problem? Please describe.
We need media support on create ad action (both photo and video)

Describe the solution you'd like
An method to upload media in the create ad modal (you can refer the create post modal in the posts section from the menu).

Additional context
Please discuss your approach before starting with the solution and refer to this issue as well #1127

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@disha1202
Copy link
Contributor

Hi,
Can I work on this?

@1010varun
Copy link
Contributor

Hey, @disha1202 if this issue is not solved yet can we both work on this??

@disha1202
Copy link
Contributor

Hi @1010varun

Here we follow one person, one issue policy. Can you please look for other open issues.

Thanks!

@disha1202
Copy link
Contributor

Hi @aashimawadhwa,

I am done with the implementation, I have added support to upload video and image in create advertisement modal.

Screen.Recording.2023-12-19.at.10.05.49.PM.mov
image

Here's the approach that I followed:

  1. Added an input of type file in AdvertisementRegister.tsx which accepts both images and videos
  2. Rendered the media in the AdvertisementEntry.tsx file using a ternary operator for checking whether it is an image or video.

Do you have any better approach in mind?
If not I'll create a PR shortly after some refactoring.

Thanks!

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants