Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Functionality for the "View" Button on Advertisement Card #1446

Closed
Vaishali054 opened this issue Jan 18, 2024 · 3 comments
Closed
Labels
bug Something isn't working unapproved

Comments

@Vaishali054
Copy link
Contributor

Describe the bug
The "View" button on the advertisement card is currently non-functional, and users are unable to access additional information such as startDate related to the advertised content. This issue is raised to propose the implementation of functionality for the "View" button to enhance user experience and provide a seamless interaction with the advertised content.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the advertisement card.
  2. Observe the presence of the "View" button.
  3. Click on the "View" button and note the lack of any response or functionality.

Expected behavior

  • Implement a modal that appears upon clicking the "View" button.
  • Ensure the modal design maintains consistency with other modals associated with Advertisement content

Actual behavior

  • The "View" button is present on the advertisement card but does not perform any action when clicked.

Screenshots
Screenshot 2023-12-09 152730

Additional details
NA

@Vaishali054 Vaishali054 added the bug Something isn't working label Jan 18, 2024
@Vaishali054
Copy link
Contributor Author

Can you please assign this to me.

@Cioppolo14
Copy link
Contributor

Thank you for your submission. This is a duplicate, as issue #1158 should address this. The PR is still open right now. I am going to close this one.

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
@Vaishali054
Copy link
Contributor Author

Vaishali054 commented Jan 19, 2024

@Cioppolo14 The problem you're addressing pertains to the media support, specifically the inability to upload custom images for advertisements. However, the issue at hand with the "view" button is distinct; currently the view button in the card doesn't do anything. It should provide additional details about the advertisement beyond what's visible on the card like the start Date. Also if the advertisement name is too long it won't be a good user experience to display the whole name on the card itself. For that too the user can see the detailed information about advertisement by clicking view button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved
Projects
None yet
Development

No branches or pull requests

2 participants