Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast Messages not working while Deleting Organization. #1108

Closed
AmitSharma512 opened this issue Dec 1, 2023 · 5 comments
Closed

Toast Messages not working while Deleting Organization. #1108

AmitSharma512 opened this issue Dec 1, 2023 · 5 comments
Assignees
Labels
bug Something isn't working no-issue-activity No issue activity

Comments

@AmitSharma512
Copy link
Contributor

Describe the bug
When we delete an organization or a sample organization, no toast message of success is shown.

To Reproduce
Steps to reproduce behaviour:

  1. Create a sample organization and an organization.
  2. Go to the settings of these organizations.
  3. Click on the Delete Organization button.
  4. Now, you can see that no toast message is shown for both the sample and the created organization.

Expected behaviour
There should be a Toast message of success whenever we Delete an organization.

Actual behaviour
No Toast message is shown whenever an organization is deleted.

Screenshots
Before fixing :
https://github.com/PalisadoesFoundation/talawa-admin/assets/110725065/a6ce0fa6-9e3c-4841-865c-066d590b66b4

Additional details
I want to work on this issue.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@AmitSharma512 AmitSharma512 added the bug Something isn't working label Dec 1, 2023
@AmitSharma512
Copy link
Contributor Author

@palisadoes I want to work on this issue

@palisadoes
Copy link
Contributor

We are now focusing on three types of issues as priority areas:

  1. The improvement in the reliability of our code base. There are many issues created to test existing code. It is a good place to start if you want to understand the operation of various apps. When you submit PRs, we automatically check to see whether the code you submitted has been covered by testing and that each file meets the minimum standard level of the repository as a whole. You won’t be able to avoid understanding testing regimes to contribute to Talawa.
  2. The fixing of bugs and features that seriously hamper the user from using the application. The apps have various shortcomings. The most obvious ones are where the apps do not work as expected. For example buttons that don’t work, errors or messages that are not displayed to make the user understand what to do and many more. Think of any difficulty you have had in getting things working, there could be a bug there waiting for you.
  3. Coding of screens for issues created by our Contributor team based on our soon to be updated design guide. This may include updates to existing screens. @rishav-jha-mech is leading this process for the Talawa Admin project
  4. The creation of additional our updated documentation that helps with improving both the experience of the end user and the various GitHub contributors who support the development of our software. This would include user guides.

We will only be accepting feature issues for deficiencies that are obviously lacking in the apps. These are things that make it very difficult to operate the apps. Even so, the PRs will still require you to understand testing as stated before.

Closing

@AmitSharma512
Copy link
Contributor Author

@palisadoes the code for the toast message is written in the code , but it is not working, I just fixed it so that the user can interact and the user can know what happened and the code is using windows.replace instead of using react routing like "Use history",
So , these are the issues which I have fixed.

@palisadoes
Copy link
Contributor

Thanks for the clarification. I'll reopen and assign it to you.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 13, 2023
@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity No issue activity
Projects
None yet
Development

No branches or pull requests

2 participants