Skip to content

Commit

Permalink
Update pull-request.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
palisadoes authored Dec 29, 2024
1 parent 36f6c2a commit c1e96c1
Showing 1 changed file with 41 additions and 42 deletions.
83 changes: 41 additions & 42 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,51 +174,50 @@ jobs:
echo "- Source branch may be incorrect please use develop as source branch."
exit 1
# Check-ESlint-Disable:
# name: Check for eslint-disable
# runs-on: ubuntu-latest
# steps:
# - name: Checkout code
# uses: actions/checkout@v4

# - name: Get changed files
# id: changed-files
# uses: tj-actions/changed-files@v45

# - name: Set up Python
# uses: actions/setup-python@v5
# with:
# python-version: 3.9

# - name: Run Python script
# run: |
# python .github/workflows/eslint_disable_check.py --files ${{ steps.changed-files.outputs.all_changed_files }}

# Check-Code-Coverage-Disable:
# name: Check for code coverage disable
# runs-on: ubuntu-latest
# steps:
# - name: Checkout code
# uses: actions/checkout@v4
Check-ESlint-Disable:
name: Check for eslint-disable
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

# - name: Get changed files
# id: changed-files
# uses: tj-actions/changed-files@v45
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v45

# - name: Set up Python
# uses: actions/setup-python@v5
# with:
# python-version: 3.9
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9

# - name: Run Python script
# run: |
# python .github/workflows/code_coverage_disable_check.py --files ${{ steps.changed-files.outputs.all_changed_files }}
- name: Run Python script
run: |
python .github/workflows/eslint_disable_check.py --files ${{ steps.changed-files.outputs.all_changed_files }}
Check-Code-Coverage-Disable:
name: Check for code coverage disable
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v45

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.9

- name: Run Python script
run: |
python .github/workflows/code_coverage_disable_check.py --files ${{ steps.changed-files.outputs.all_changed_files }}
Test-Application:
name: Test Application
runs-on: ubuntu-latest
needs: [Code-Quality-Checks]
# needs: [Code-Quality-Checks, Check-ESlint-Disable,Check-Code-Coverage-Disable]
needs: [Code-Quality-Checks, Check-ESlint-Disable,Check-Code-Coverage-Disable]
steps:
- name: Checkout the Repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -436,8 +435,8 @@ jobs:
name: Test Deployment to https://docs-admin.talawa.io
runs-on: ubuntu-latest
needs: [Docker-Start-Check, Start-App-Without-Docker]
# Run only if the develop branch and not dependabot
if: ${{ github.actor != 'dependabot[bot]' && github.event.pull_request.base.ref == 'develop' }}
# Run only if the develop-postgres branch and not dependabot
if: ${{ github.actor != 'dependabot[bot]' && github.event.pull_request.base.ref == 'develop-postgres' }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -459,7 +458,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check if the target branch is develop
if: github.event.pull_request.base.ref != 'develop'
if: github.event.pull_request.base.ref != 'develop-postgres'
run: |
echo "Error: Pull request target branch must be 'develop'. Please refer PR_GUIDELINES.md"
echo "Error: Pull request target branch must be 'develop-postgres'. Please refer PR_GUIDELINES.md"
exit 1

0 comments on commit c1e96c1

Please sign in to comment.