schedule presync stf events to the first sync block #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It could be useful to add any detail you think is missing about presync handling to the docs (https://docs.paimastudios.com/home/react-to-events/funnel-types/intro) that way everybody on the team has a document to refer to on how presync handling works then we can review all the primitives and make sure they follow the same behavior we specify in the docs, since for example: Primitives that don't schedule during the presync:
Primitives that schedule during the presync:
|
ecioppettini
force-pushed
the
enzo/restore-presync-scheduled-data-behavior
branch
from
15f41a9 to
3d9cbf6
Compare
This was referenced Apr 15, 2024
SebastienGllmt
approved these changes
Apr 17, 2024
SpaceManiac
added a commit
that referenced
this pull request
Apr 17, 2024
SebastienGllmt
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Add ERC1155Contract artifacts extracted from hardhat build * Add IInverseAppProjected1155 artifacts extracted from hardhat build * Import 1155 contract into paima-utils/contracts.ts * Add configuration and data types for 'erc1155-app' * Fix 1055 typo * Add ERC-1155 stuff to paima-sm * Add ERC-1155 stuff to paima-funnel * Read ERC-1155 TransferSingle and TransferBatch events into Transfer datums * Add value to mint event * npm run prettier * Remove leftover base ERC1155Contract files * Rename InverseAppProjected1155Transfer -> Erc1155Transfer, 'erc1155-app' to 'erc1155' * Add IERC1155Contract.json & .ts * Add Erc1155 base contract types * Make logic inside isPaimaErc721 reusable * Expose just ERC-1155 transfer datums, expand rather than flatten them * JSON-encode ids and values lists in scheduled data * Remove contractAddress from ERC-1155 transfer scheduled data * Add cde_erc1155_data and cde_erc1155_burn tables and queries * Actually update data + burn tables * Revert "Make logic inside isPaimaErc721 reusable" This reverts commit 471a81e. * Remove mint leftover from cdeTransitionFunction * Apply presync change from #339 * Remove remaining InverseAppProjected1155 types in favor of stock Erc1155 * Pre-lowercase addresses in ERC-1155 transfer scheduled event * Improve cde-config error logging * Remove unintended depositAddress config field * npm run prettier * Add query functions for ERC-1155 support * Make 'erc-1155' scheduledPrefix optional, add optional burnScheduledPrefix * Fix stale filename in contract-types import * Added get erc1155 token by id * Fixed return type * Fix /src import * Update loadAbi docs * Remove sketchy getERC1155TotalBalanceAllTokens helper --------- Co-authored-by: Edward Alvarado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the change to the scheduled behavior in #314 may have been a mistake. I thought that presync data was being scheduled with the original block which didn't make sense and was useless, but that only happened because of the
Math.maxusage and the block heights in the parallel chain being bigger (in particular, with emulated blocks this is always the case sinceSM_START_BLOCKHEIGHTis 0) . Also, that PR didn't fix the issue for the carp/cardano primitives.So this restores the behavior to the way it worked before that PR for the scheduled data, but also fixes the original issue for the parallel evm and carp funnels.
If we actually don't want to schedule data during the presync like we are doing currently, we still should do it in the carp primitives. But I imagine it's actually more practical to schedule everything in the first stf? The only potential issue is that the first state transition could take a while if there is a lot of presync data.