small refactor in funnel cursors filtering

PaimaStudios · Apr 18, 2024 · b2a8428 · b2a8428
1 parent d99b36b
commit b2a8428
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/packages/engine/paima-funnel/src/funnels/carp/funnel.ts b/packages/engine/paima-funnel/src/funnels/carp/funnel.ts
@@ -459,17 +459,21 @@ export class CarpFunnel extends BaseFunnel implements ChainFunnel {
       const cursors = await getPaginationCursors.run(undefined, dbTx);
 
       const extensions = sharedData.extensions
-        .filter(extensions => extensions.network === config.network)
-        .map(extension => extension.cdeId);
-
-      for (const cursor of cursors) {
-        // TODO: performance concern? but not likely
-        if (extensions.find(cdeId => cdeId === cursor.cde_id))
+        .filter(extensions => extensions.network === chainName)
+        .map(extension => extension.cdeId)
+        .reduce((set, cdeId) => {
+          set.add(cdeId);
+          return set;
+        }, new Set());
+
+      cursors
+        .filter(cursor => extensions.has(cursor.cde_id))
+        .forEach(cursor => {
           newEntry.updateCursor(cursor.cde_id, {
             cursor: cursor.cursor,
             finished: cursor.finished,
           });
-      }
+        });
 
       return newEntry;
     })();

diff --git a/packages/engine/paima-funnel/src/funnels/mina/funnel.ts b/packages/engine/paima-funnel/src/funnels/mina/funnel.ts
@@ -378,16 +378,20 @@ export class MinaFunnel extends BaseFunnel implements ChainFunnel {
 
       const extensions = sharedData.extensions
         .filter(extensions => extensions.network === chainName)
-        .map(extension => extension.cdeId);
-
-      for (const cursor of cursors) {
-        // TODO: performance concern? but not likely
-        if (extensions.find(cdeId => cdeId === cursor.cde_id))
+        .map(extension => extension.cdeId)
+        .reduce((set, cdeId) => {
+          set.add(cdeId);
+          return set;
+        }, new Set());
+
+      cursors
+        .filter(cursor => extensions.has(cursor.cde_id))
+        .forEach(cursor => {
           newEntry.updateCursor(cursor.cde_id, {
             cursor: cursor.cursor,
             finished: cursor.finished,
           });
-      }
+        });
 
       return newEntry;
     })();