Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure detection fixes & clean qemu shutdown #7

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

gratux
Copy link
Contributor

@gratux gratux commented Jan 20, 2024

During this semester of OS, we had the pleasure of using your tool.
We noticed some issues with test status detection:

  • timeouts were displayed in the log, but not counted towards the overall status. As such, when all tests either pass or timeout, tortillas yields success as the exit code.
  • if someone disabled vital kernel logs (i.e. SYSCALL for exit code detection), tortillas didn't detect any failures and marked tests as success. In our opinion, it should instead mark tests expecting a specific exit code as failed, since no exit code was found at all.

Additionally, we added a clean QEMU shutdown, so changes to the file system are committed to disk. One may then inspect the image and its contents afterwards.

@PaideiaDilemma
Copy link
Owner

PaideiaDilemma commented Jan 21, 2024

Thanks for making this PR!

@PaideiaDilemma PaideiaDilemma merged commit 162fd1b into PaideiaDilemma:main Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants