Skip to content

Commit

Permalink
no logs should trigger missing exit codes
Browse files Browse the repository at this point in the history
  • Loading branch information
gratux committed Jan 11, 2024
1 parent 7afcc1c commit c67dfbe
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tortillas/log_analyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,11 @@ def analyze(
else TestStatus[config_entry.set_status]
)

if not logs:
continue
# fixme: this is flawed, why is this here?
# when tortillas gets no logs and and aborts, it can't detect incorrect or missing exit codes
# as a result, every test with incorrect exit codes passes
# if not logs:
# continue

if config_entry.mode == "add_as_error":
result.add_errors(logs, status)
Expand Down

0 comments on commit c67dfbe

Please sign in to comment.