AA-1837 Add only_invocable_on_unresolved_incidents to Automation Action's schema. #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannagreen1
force-pushed
the
AA-1837
branch
from
060a8a6
to
c4261f0
Compare
juliannagreen1
changed the title
juliannagreen1
force-pushed
the
AA-1837
branch
from
c4261f0
to
aa93eab
Compare
cjgajard
reviewed
Nov 7, 2024
| @@ -214,7 +218,8 @@ resource "pagerduty_automation_actions_action" "foo" { | |||
| process_automation_job_id = "pa_job_id_123" | |||
| process_automation_job_arguments = "-arg 1" | |||
| process_automation_node_filter = "tags: production" | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
The trailing comma is breaking the test
cjgajard
reviewed
Nov 7, 2024
| @@ -75,6 +75,7 @@ resource "pagerduty_automation_actions_action" "test" { | |||
| process_automation_job_arguments = "-arg 1" | |||
| process_automation_node_filter = "tags: production" | |||
| } | |||
| only_invocable_on_unresolved_incidents: true | |||
cjgajard
reviewed
Nov 7, 2024
| @@ -298,6 +308,10 @@ func resourcePagerDutyAutomationActionsActionRead(d *schema.ResourceData, meta i | |||
| if automationActionsAction.ActionClassification != nil { | |||
| d.Set("action_classification", &automationActionsAction.ActionClassification) | |||
| } | |||
|
|
|||
| if automationActionsAction.OnlyInvocableOnUnresolvedIncidents != nil { | |||
| d.Set("only_invocable_on_unresolved_incidents", &automationActionsAction.OnlyInvocableOnUnresolvedIncidents) | |||
There was a problem hiding this comment.
As automationActionsAction.OnlyInvocableOnUnresolvedIncidents is a pointer to bool the value should be its dereference (i.e. use * instead of &).
cjgajard
reviewed
Nov 7, 2024
| @@ -84,6 +85,7 @@ func TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic(t *testi | |||
| resource.TestCheckResourceAttrSet("pagerduty_automation_actions_action.foo", "modify_time"), | |||
| resource.TestCheckResourceAttrSet("pagerduty_automation_actions_action.foo", "runner_id"), | |||
| resource.TestCheckResourceAttr("pagerduty_automation_actions_action.foo", "runner_type", "runbook"), | |||
| resource.TestCheckResourceAttr("pagerduty_automation_actions_action.foo", "only_invocable_on_unresolved_incidents", "true"), | |||
There was a problem hiding this comment.
please, test the "false" value here setting explicitly the value in testAccCheckPagerDutyAutomationActionsActionTypeProcessAutomationConfigUpdated
cjgajard
reviewed
Nov 7, 2024
| @@ -153,6 +158,11 @@ func buildAutomationActionsActionStruct(d *schema.ResourceData) (*pagerduty.Auto | |||
| automationActionsAction.ModifyTime = &val | |||
| } | |||
|
|
|||
| if attr, ok := d.GetOk("only_invocable_on_unresolved_incidents"); ok { | |||
There was a problem hiding this comment.
GetOk will return ok equal to false even when the value is explicitly set to false. Since the client defines this field as omitempty it would never get changed to false.
I'd change this whole if block to:
attr, _ := d.Get("only_invocable_on_unresolved_incidents").(bool)
automationActionsAction.OnlyInvocableOnUnresolvedIncidents = &attr
|
Thank you for your contribution @juliannagreen1 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new field
only_invocable_on_unresolved_incidentsto Automation Action's schema.