Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 6 and above configs_for #5

Closed
wants to merge 1 commit into from
Closed

Add support for Rails 6 and above configs_for #5

wants to merge 1 commit into from

Conversation

DougEdey
Copy link

@DougEdey DougEdey commented May 4, 2022

Currently, when running against Rails 6 or above the following warning is emitted:

DEPRECATION WARNING: [] is deprecated and will be removed from Rails 7.0 (Use configs_for) (called from with_connection at /Users/dougedey/src/gitlab/OpsLevel/app/helpers/database_helper.rb:32)

Rails 6.1 switched to using configs_for to support multi-database better: rails/rails#33637

Instead of forcing people off Standby, I figured it was easier to support the new and old mechanisms.

And the PagerDuty fork seems to be the most in use repo so I figured it was the best one to patch, let me know if you're not accepting PRs and I'll continue on my own fork.

This is a more complete version of the upstream PR kenn#38

@DougEdey DougEdey closed this by deleting the head repository Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant