fail when parameter not defined #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can not merge this into 1.x because this is a breaking change. |
abdularis
reviewed
Jun 1, 2021
There was a problem hiding this comment.
@generikvault do you have test or update the test if already exist for this?
| @@ -1,3 +1,5 @@ | |||
| module github.com/PaesslerAG/gval | |||
|
|
|||
| go 1.14 | |||
There was a problem hiding this comment.
I think it's not sync with the latest main branch, should be 1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test that is failing is occurring even in master so it is nothing to do with my changes.
resolve #49