Add ROS 2 humble. Update ROS 2 dockerfile to take args for the ros ve… #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion and base image. Update rolling to jammy.
This was referenced Aug 13, 2023
awaisali88
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rsion and base image. Update rolling to jammy.
Rather than copying the Dockerfile again, I updated the rolling Dockerfile to have 2 args to handle different versions of ROS 2. I also switched the installation of FastDDS installation to the Micro-XRCE-DDS-Agent.
This could probably be cleaned up a little more with a matrix to list the distros and base images.