Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

RRT global planner #672

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

brunopinto900
Copy link

Hello,

This pull request is the continuation of #453 . The main changes are:

RRT star is used to generate global paths;
Octomap is used as the map framework;
The drone's yaw is set to the direction of the path;

There are some issues to discuss:

The controller works in a time-based loop where the setpoint is just the next point of the path. It leads to non-smooth motion of the drone. Need to discuss how to give waypoints to the controller.
Parameters are now hardcoded. Need to discuss where to put them. Launch file, YAML or dynamic reconfig?

Thank you.

Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brunopinto900 Before I dive into the PR further,

  • Do you have logs/videos that show the overall behavior of the implementation? I would like to see if what I see in my setup is consistent with what you have implemented
  • There seems to be some EOF missing from the file. (Probably from my PR before)

The controller works in a time-based loop where the setpoint is just the next point of the path. It leads to non-smooth motion of the drone. Need to discuss how to give waypoints to the controller.

I would say the best way for now is to work with line segments and follow them as a reference "path". This can be done by getting the closest point on the line segment and using it as a reference


ros::spin();
return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mission EOF

}
}

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOF

double planYaw();
};

#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOF

};
} // namespace ompl

#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOF

@brunopinto900
Copy link
Author

Hello,

I can send you a video with the expected result from the implementation. I don't have any idea of what caused the missing EOF.

@brunopinto900
Copy link
Author

screenrecording.1.mp4

The planner works fine. The drone crashed in the end due to:

Octomap obstacles should be inflated
The controller is very basic.

@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Mar 18, 2022

I don't have any idea of what caused the missing EOF.

https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline You should add a newline at the end of each file

Octomap obstacles should be inflated
The controller is very basic.

Okay, we need to fix these issues before we can merge it in

@brunopinto900
Copy link
Author

@Jaeyoung-Lim Okay. I will fix the octomap inflation, the controller as well as the EOF.

@Cavalletta98
Copy link

When will be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants