Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces new classes for maintainability ✂️ #170

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mdreano
Copy link

@mdreano mdreano commented Feb 27, 2024

First of all, thank you for sharing this repository it has been a really helpful introduction for me ❤️

Extracted some logic in separate classes:

  • reward.py: responsible for logic around rewards
  • pyboy_reader.py: reads from pyboy memory
  • baselines_usils.py: util method to create or load env

Dissociate updating rewards from reading rewards.
This is easily seen in the step function of the gym.

Added "Stream" in config
Allows to tell if you want to stream to the shared map.

Added "seen_pokemon" reward

Added the current location in the print_reward

Moved sessions in a "session" folder

@mdreano mdreano changed the title introduces new classes for maintability Introduces new classes for maintability ✂️ Feb 29, 2024
Signed-off-by: Mathieu D <[email protected]>
Signed-off-by: Mathieu D <[email protected]>
Signed-off-by: Mathieu D <[email protected]>
@mdreano mdreano changed the title Introduces new classes for maintability ✂️ Introduces new classes for maintainability ✂️ Mar 3, 2024
Signed-off-by: Mathieu D <[email protected]>
Signed-off-by: Mathieu D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant