Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint selection #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RJ-246
Copy link

@RJ-246 RJ-246 commented Oct 23, 2023

Added a function that allows you to choose a session to resume training from instead of hard coding it. It chooses the steps zip with the largest number inside the session folder.

Added a function that allows users to select a checkpoint for the training session.
Added option for user to select checkpoint
@PWhiddy
Copy link
Owner

PWhiddy commented Oct 23, 2023

Hey, thanks for opening a PR!

So this gives a menu of sessions to start from? Sounds nice. I think it could be factored into it's own file so it doesn't have to be duplicated across files. And it also would could be applied to the run_pretrained script.

This prompts you every time no matter what though? It would be great if by default you weren't required to do this every time, maybe it could be enabled with a flag or cli argument?

@RJ-246
Copy link
Author

RJ-246 commented Oct 23, 2023

Good ideas, I'll keep working on it. What would you see as being the default session used if the flag wasn't used?

@PWhiddy
Copy link
Owner

PWhiddy commented Oct 23, 2023

I think there should still be a hardcoded file_name variable, and if it can't be found or is set to something special like "automatic" or "prompt" it will give you the menu. I didn't get to inspect the code too closely yet but one of the menu options should be starting from scratch of course.

Also make sure to pull this change I just merged in:
#105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants