Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up #137

Merged
merged 1 commit into from
Dec 21, 2023
Merged

clean up #137

merged 1 commit into from
Dec 21, 2023

Conversation

ckolbPTB
Copy link
Collaborator

This fixes #126 and hopefully makes the rest of the code a bit more consistent.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms
   _remove_readout_os.py30293%47, 49
src/mrpro/data
   _AccelerationFactor.py13130%15–36
   _AcqInfo.py64198%93
   _DcfData.py78396%71, 97, 178
   _IData.py57788%43, 48, 109, 114, 122, 128, 132
   _IHeader.py58297%86, 113
   _KData.py86693%83–84, 126, 153, 158–159
   _KHeader.py125993%34, 81, 119, 170, 181, 188–189, 192, 199
   _KNoise.py21957%48–61
   _SpatialDimension.py39587%74, 77, 84–86
   _TrajectoryDescription.py14193%35
src/mrpro/data/traj_calculators
   _KTrajectoryCalculator.py16194%37
   _KTrajectoryIsmrmrd.py16288%55, 65
   _KTrajectoryPulseq.py36197%72
   _KTrajectoryRadial2D.py26292%49, 53
   _KTrajectoryRpe.py43295%109, 111
src/mrpro/operators
   _FourierOp.py116695%43–50, 198, 248
   _LinearOperator.py21386%28, 47, 52
   _Operator.py8188%27
src/mrpro/utils
   _rgetattr.py3167%20
TOTAL13187794% 

Tests Skipped Failures Errors Time
74 0 💤 0 ❌ 0 🔥 31.129s ⏱️

@fzimmermann89
Copy link
Member

Re the other dimension:

I would prefer if we allow in our code for this dimension to actually be more than 1 dimensnion.
So we dont split the KData into dynamics, ... by default, but our code works if it is split.

This would, as a start, mean replacing 'other' by '...' in all einops pattern, and counting dimensions from the back for swapaxes etc.

What do you think, Christoph?

@ckolbPTB
Copy link
Collaborator Author

I think any change which makes the code more general is a good idea. As this will probably require more changes than a few clean-up ones, I created an issue for this #138

@ckolbPTB ckolbPTB merged commit d672b6d into main Dec 21, 2023
4 checks passed
@ckolbPTB ckolbPTB deleted the cleanup branch December 21, 2023 15:08
fzimmermann89 pushed a commit that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SensitivityOp interface
2 participants