Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docu for users and devs extended #121

Merged
merged 1 commit into from
Dec 7, 2023
Merged

docu for users and devs extended #121

merged 1 commit into from
Dec 7, 2023

Conversation

ckolbPTB
Copy link
Collaborator

@ckolbPTB ckolbPTB commented Dec 4, 2023

Closes #106

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/mrpro/algorithms
   _remove_readout_os.py30293%47, 49
src/mrpro/data
   _AccelerationFactor.py13130%15–36
   _AcqInfo.py64198%93
   _DcfData.py78396%71, 97, 178
   _KData.py86693%82–83, 125, 152, 157–158
   _KHeader.py125993%34, 81, 119, 170, 181, 188–189, 192, 199
   _KNoise.py21957%48–61
   _SpatialDimension.py39587%74, 77, 84–86
   _TrajectoryDescription.py14193%35
src/mrpro/data/traj_calculators
   _KTrajectoryCalculator.py16194%37
   _KTrajectoryIsmrmrd.py16288%55, 65
   _KTrajectoryPulseq.py36197%69
   _KTrajectoryRadial2D.py26292%49, 53
   _KTrajectoryRpe.py43295%110, 112
src/mrpro/utils
   _rgetattr.py3167%20
TOTAL11045895% 

Tests Skipped Failures Errors Time
63 0 💤 0 ❌ 0 🔥 17.139s ⏱️

@ckolbPTB
Copy link
Collaborator Author

ckolbPTB commented Dec 4, 2023

@schote I know this is very basic but can you think of anything which is missing but absolutely necessary (or easy to add)? If you have an example of a good documentation of another repo, this would also be very helpful.

@schote
Copy link
Collaborator

schote commented Dec 5, 2023

@schote I know this is very basic but can you think of anything which is missing but absolutely necessary (or easy to add)? If you have an example of a good documentation of another repo, this would also be very helpful.

In my opinion scikit-learn has a good documentation, which we could use as a reference. I think as soon as we have our first release and a release strategy (in case this is planned at some point) we should add:

  • versioning to indicate the version the documentation refers to
  • changelog
  • timeline to indicate what future implementations are planned (could be helpful if one needs to make a decision whether or not the package is suitable or will be suitable)

Besides that I would add some minimal examples. I think you also already have that in mind with the notebooks, right @ckolbPTB ?

@ckolbPTB
Copy link
Collaborator Author

ckolbPTB commented Dec 7, 2023

scikit-learn has a very nice documentation - might be a bit too ambitious for us but let's see.

Yes, the examples will be done via automatically creating jupyter notebooks PR #118

I added an issue regarding the versionen and release strategy #125

@schote Could you do a quick review of these changes such that I can merge them before the hackathon next week? thanks!

Copy link
Collaborator

@schote schote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation helps a lot to better understand the structure of the repository 👍🏼

@ckolbPTB ckolbPTB merged commit 770376b into main Dec 7, 2023
4 checks passed
@ckolbPTB ckolbPTB deleted the add_user_dev_docu branch December 7, 2023 19:56
fzimmermann89 pushed a commit that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Software/Repository Architecture Description
2 participants