Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows PowerShell #117

Closed
wants to merge 23 commits into from
Closed

Support Windows PowerShell #117

wants to merge 23 commits into from

Conversation

MariusStorhaug
Copy link
Contributor

Description

  • Enable tests for Windows PowerShell.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner August 11, 2024 12:28
@MariusStorhaug
Copy link
Contributor Author

Its too expensive.

  • Need rework of ConvertFrom-Json, -AsHashtable is not supported.
  • Need rework of Invoke-GitHubAPI, as -FollowRelLink, HttpVersion, Authentication, Token ++ is not supported in Windows PowerShell 5.1. HttpVersion is not even supported in 7.2.

This then serves as a reminder that we will only support the latest version of PowerShell, assuming that developers that use GitHub actually can install PowerShell (core) on their machines.

@MariusStorhaug MariusStorhaug deleted the desktopSupport branch August 11, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant