Set n_workers for dask LocalCluster #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicity set n_workers for LocalCluster creation (through Client). If this is not set, for machines with a high CPU count, the number of workers will be much larger than 7. In `client.scatter` with `broadcast=True`, this can cause hangs due to how dask distributed works. It's presumed that this bug is only apparent in more recent runs on machines with high CPU counts, although that is not confirmed. But, this fix does allow the example to run to completion on a machine with CPU_COUNT=128.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 24 24
Lines 1616 1616
=======================================
Hits 1192 1192
Misses 424 424
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks great and ran well on my machine. Merging. Thanks @talumbau! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.scatterwithbroadcast=True, this can cause hangs due to how dask distributed works. It's presumed that this bug is only apparent in more recent runs on machines with high CPU counts, although that is not confirmed. But, this fix does allow the example to run to completion on a machine with CPU_COUNT=128.