Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off plotting by default #101

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

jdebacker
Copy link
Member

This PR turns off all plots in the calibration files as the default. The run_og_usa.py script still produces and saves some plots of the output to disk after the baseline and reform runs complete.

cc @talumbau @rickecon

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (4c0e3d8) to head (f01b59b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   78.70%   75.41%   -3.30%     
==========================================
  Files          11       11              
  Lines         850      850              
==========================================
- Hits          669      641      -28     
- Misses        181      209      +28     
Flag Coverage Δ
unittests 75.41% <ø> (-3.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogusa/bequest_transmission.py 56.52% <ø> (-34.79%) ⬇️
ogusa/calibrate.py 37.41% <ø> (ø)
ogusa/transfer_distribution.py 62.79% <ø> (-27.91%) ⬇️

@rickecon
Copy link
Member

@jdebacker. Thanks for this. Looks great. Merging.

@rickecon rickecon merged commit 13a3da8 into PSLmodels:master Apr 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants