Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test minimum versions of dependencies #2112

Merged
merged 7 commits into from
Oct 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,27 @@ jobs:
working-directory: prqlc/prqlc
run: cargo msrv verify

test-deps-min-versions:
runs-on: ubuntu-latest
needs: rules
if: needs.rules.outputs.nightly == 'true'
steps:
- name: 📂 Checkout code
uses: actions/checkout@v3
- run: rustup toolchain add nightly
- uses: baptiste0928/cargo-install@v2
with:
crate: cargo-hack
- uses: baptiste0928/cargo-install@v2
with:
crate: cargo-minimal-versions
- name: 💰 Cache
uses: Swatinem/rust-cache@v2
with:
save-if: ${{ github.ref == 'refs/heads/main' }}
- name: Verify minimum rust version
run: cargo minimal-versions test

check-ok-to-merge:
# This indicates to GitHub whether everything in this workflow has passed
# and (unlike if we included each task in the branch's GitHub required
Expand Down
12 changes: 2 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion prqlc/prql-compiler/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ mysql = {version = "24", optional = true}
pg_bigdecimal = {version = "0.1", optional = true}
postgres = {version = "0.19", optional = true}
rusqlite = {version = "0.29.0", optional = true, features = ["bundled", "csvtab"]}
tiberius = {version = "0.12", optional = true, features = ["sql-browser-tokio", "bigdecimal", "time"]}
tiberius = {version = "0.12.2", optional = true, features = ["sql-browser-tokio", "bigdecimal", "time"]}
tokio = {version = "1", optional = true, features = ["full"]}
tokio-util = {version = "0.7", optional = true, features = ["compat"]}

Expand Down
4 changes: 3 additions & 1 deletion prqlc/prqlc-parser/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@ doctest = false

[dependencies]
itertools = "0.11.0"
prqlc-ast = {path = "../prqlc-ast", version = "0.10.1" }
prqlc-ast = {path = "../prqlc-ast", version = "0.10.1"}
semver = {version = "1.0.20"}

# Chumsky's default features have issues when running in wasm (though we only
# see it when compiling on MacOS), so we only include features when running
# outside wasm.
[target.'cfg(not(target_family="wasm"))'.dependencies]
chumsky = "0.9.2"
# Not direct dependencies, but pinning because of bugs in previous versions
stacker = "0.1.15"
[target.'cfg(target_family="wasm")'.dependencies]
chumsky = {version = "0.9.2", features = ["ahash", "std"], default-features = false}

Expand Down
8 changes: 6 additions & 2 deletions prqlc/prqlc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,18 @@ colorchoice-clap = "1.0.0"
env_logger = {version = "0.10.0", features = ["color"]}
itertools = "0.11.0"
notify = "6.1.1"
prqlc-ast = {path = '../prqlc-ast', version = "0.10.1" }
prql-compiler = {path = '../prql-compiler', features = ["serde_yaml"], version = "0.10.1" }
prql-compiler = {path = '../prql-compiler', features = ["serde_yaml"], version = "0.10.1"}
prqlc-ast = {path = '../prqlc-ast', version = "0.10.1"}
regex = {version = "1.10.2", features = ["std", "unicode"]}
serde = "1"
serde_json = "1.0.107"
serde_yaml = "0.9.25"
walkdir = "2.4.0"

# Not direct dependencies, but pinning because of bugs in previous versions. Can
# remove when dependencies no longer use it. (If CI passes, it can be removed.)
clap_complete = "4.4.1"

# We use minijinja just for the Jinja lexer, which is not part of the
# public interface which is covered by semver guarantees.
minijinja = {version = "=0.31.0", features = ["unstable_machinery"]}
Expand Down
2 changes: 1 addition & 1 deletion web/book/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ itertools = "0.11.0"
mdbook = {version = "0.4.35", default-features = false}
mdbook-preprocessor-boilerplate = "0.1.2"
prql-compiler = {path = "../../prqlc/prql-compiler", default-features = false}
pulldown-cmark = "0.9.3"
pulldown-cmark = {version = "0.9.3", default-features = false}
pulldown-cmark-to-cmark = "11.0.0"
strum = {version = "0.25.0", features = ["std", "derive"]}
strum_macros = "0.25.3"
Expand Down
Loading