Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing in pore scale models #2889

Merged
merged 4 commits into from
Jan 26, 2024

adding check to prevent negative numbers

51c3715
Select commit
Loading
Failed to load commit list.
Merged

Fixing in pore scale models #2889

adding check to prevent negative numbers
51c3715
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 26, 2024 in 0s

69.2% of diff hit (target 89.8%)

View this Pull Request on Codecov

69.2% of diff hit (target 89.8%)

Annotations

Check warning on line 4 in openpnm/models/_doctxt.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/models/_doctxt.py#L3-L4

Added lines #L3 - L4 were not covered by tests

Check warning on line 4 in openpnm/models/geometry/_geodocs.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/models/geometry/_geodocs.py#L3-L4

Added lines #L3 - L4 were not covered by tests

Check warning on line 78 in openpnm/models/misc/_neighbor_lookups.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/models/misc/_neighbor_lookups.py#L75-L78

Added lines #L75 - L78 were not covered by tests

Check warning on line 135 in openpnm/models/misc/_neighbor_lookups.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/models/misc/_neighbor_lookups.py#L135

Added line #L135 was not covered by tests

Check warning on line 4 in openpnm/models/phase/_phasedocs.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/models/phase/_phasedocs.py#L3-L4

Added lines #L3 - L4 were not covered by tests

Check warning on line 45 in openpnm/utils/_workspace.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/utils/_workspace.py#L45

Added line #L45 was not covered by tests

Check warning on line 52 in openpnm/utils/_workspace.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/utils/_workspace.py#L50-L52

Added lines #L50 - L52 were not covered by tests

Check warning on line 56 in openpnm/utils/_workspace.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

openpnm/utils/_workspace.py#L56

Added line #L56 was not covered by tests