Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing conductance shape from Nt by 1 to Nt by 2 for ALL conductance models #2849

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Changing conductance shape from Nt by 1 to Nt by 2 for ALL conductance models #2849

wants to merge 7 commits into from

Commits on Oct 26, 2023

  1. write unit tests to check conductance shape

    @mkaguer
    mkaguer committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9969424 View commit details
    Browse the repository at this point in the history

  2. ensure _poission_conductance returns shape of Nt by 2

    @mkaguer
    mkaguer committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3fd92ca View commit details
    Browse the repository at this point in the history

  3. ensure hydraulic conductance models return array of shape Nt by 2

    @mkaguer
    mkaguer committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    b771d07 View commit details
    Browse the repository at this point in the history

  4. ensure taylor aris conductance returns Nt by 2 array

    @mkaguer
    mkaguer committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9ef473f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Fixed bug with ad_dif_conductance assuming gh is Nt by 1

    @mkaguer
    mkaguer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9569b2f View commit details
    Browse the repository at this point in the history

  2. fixed set_outflow_BC for case where gh is Nt by 2

    @mkaguer
    mkaguer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    fd172f7 View commit details
    Browse the repository at this point in the history

  3. fixed simulating transport notebook so hardcoded gh is Nt by 2

    @mkaguer
    mkaguer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    e2ec2b0 View commit details
    Browse the repository at this point in the history